Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

Thank you for your detailed explanation! It would seem perfectly reasonable to define the behavior in this case, at least (and I suppose not only) to me. Attila 2016-12-20 14:50 GMT+01:00 Aaron Ballman : > On Tue, Dec 20, 2016 at 7:58 AM, Attila Török

Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

On Tue, Dec 20, 2016 at 7:58 AM, Attila Török wrote: > I did not see that it was reapplied later, sorry. > > With clang version 3.9.0 (tags/RELEASE_390/final) I get the warning in both > c11 and c++11 mode. > With clang version 4.0.0 (trunk 290146) (llvm/trunk 290118) it's

Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

I did not see that it was reapplied later, sorry. With clang version 3.9.0 (tags/RELEASE_390/final) I get the warning in both c11 and c++11 mode. With clang version 4.0.0 (trunk 290146) (llvm/trunk 290118) it's gone in c11 mode, but still there in c++11. The piece of code I tested it on:

Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

On Fri, Dec 16, 2016 at 7:00 AM, Attila Török via Phabricator wrote: > torokati44 added a comment. > > I see this has been reverted in r281612, but I can no longer access the build > log serving as a reason linked in the message: >

[PATCH] D23921: Remove va_start diagnostic false positive with enumerations

torokati44 added a comment. I see this has been reverted in r281612, but I can no longer access the build log serving as a reason linked in the message: https://www.mail-archive.com/cfe-commits@lists.llvm.org/msg35386.html We have a few false-positive warnings that (I think) would be silenced

Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

aaron.ballman closed this revision. aaron.ballman added a comment. Commit in r281609 https://reviews.llvm.org/D23921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

LGTM On 14 Sep 2016 2:36 pm, "Dimitry Andric" wrote: dim added a comment. FWIW, I have already imported this fix into FreeBSD two weeks ago: https://svnweb.freebsd.org/changeset/base/304960 It has been working fine for us. https://reviews.llvm.org/D23921

Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

dim added a comment. FWIW, I have already imported this fix into FreeBSD two weeks ago: https://svnweb.freebsd.org/changeset/base/304960 It has been working fine for us. https://reviews.llvm.org/D23921 ___ cfe-commits mailing list

Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

aaron.ballman added a comment. In https://reviews.llvm.org/D23921#531883, @aaron.ballman wrote: > Ping Ping https://reviews.llvm.org/D23921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

aaron.ballman added a comment. Ping https://reviews.llvm.org/D23921 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23921: Remove va_start diagnostic false positive with enumerations

dim added a subscriber: dim. dim added a comment. This works for me. I had two test cases from the FreeBSD source tree which resulted in warnings, e.g.: cddl/contrib/opensolaris/lib/libnvpair/libnvpair.c:388:15: error: passing an object that undergoes default argument promotion to

[PATCH] D23921: Remove va_start diagnostic false positive with enumerations

aaron.ballman created this revision. aaron.ballman added reviewers: rsmith, dblaikie, rtrieu, friss. aaron.ballman added a subscriber: cfe-commits. r267338 improved the diagnostic checking for undefined behavior with va_start(), but it had some false positives regarding enumerations. The