Re: [PATCH] D23945: clang-cl: Support MSVC2015's /validate-charset flag.

2016-08-26 Thread Nico Weber via cfe-commits
thakis closed this revision. thakis added a comment. r279872, thanks! https://reviews.llvm.org/D23945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D23945: clang-cl: Support MSVC2015's /validate-charset flag.

2016-08-26 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm https://reviews.llvm.org/D23945 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[PATCH] D23945: clang-cl: Support MSVC2015's /validate-charset flag.

2016-08-26 Thread Nico Weber via cfe-commits
thakis created this revision. thakis added a reviewer: hans. thakis added a subscriber: cfe-commits. Clang always assumes that files are utf-8. If an invalidly encoded character is used in an identifier, clang always errors. If it's used in a character literal, clang warns Winvalid-source-encodi