Re: [PATCH] D23973: clang-format: [JS] handle default bindings in imports.

2016-09-02 Thread Martin Probst via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL280486: clang-format: [JS] handle default bindings in imports. (authored by mprobst). Changed prior to commit: https://reviews.llvm.org/D23973?vs=69514&id=70159#toc Repository: rL LLVM https://revie

Re: [PATCH] D23973: clang-format: [JS] handle default bindings in imports.

2016-09-02 Thread Martin Probst via cfe-commits
mprobst added a comment. In https://reviews.llvm.org/D23973#532801, @djasper wrote: > It would be helpful to have a before/after to review these patches. I assumed the test case was clear enough. Before, we couldn't parse default bindings at all, after, we do, and thus sort the imports in the

Re: [PATCH] D23973: clang-format: [JS] handle default bindings in imports.

2016-09-02 Thread Daniel Jasper via cfe-commits
djasper accepted this revision. djasper added a comment. This revision is now accepted and ready to land. It would be helpful to have a before/after to review these patches. https://reviews.llvm.org/D23973 ___ cfe-commits mailing list cfe-commits@li

Re: [PATCH] D23973: clang-format: [JS] handle default bindings in imports.

2016-09-02 Thread Martin Probst via cfe-commits
mprobst added a comment. Friendly ping. https://reviews.llvm.org/D23973 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D23973: clang-format: [JS] handle default bindings in imports.

2016-08-28 Thread Martin Probst via cfe-commits
mprobst created this revision. mprobst added a reviewer: djasper. mprobst added a subscriber: cfe-commits. Herald added a subscriber: klimek. Default imports appear outside of named bindings in curly braces: import A from 'a'; import A, {symbol} from 'a'; https://reviews.llvm.org/D23973 Fil