mgorny created this revision.
mgorny added reviewers: samsonov, Hahnfeld.
mgorny added a subscriber: cfe-commits.
Herald added a subscriber: dberris.
Support overriding LLVM_* variables obtained from llvm-config when doing
stand-alone builds. The override of LLVM_MAIN_SRC_DIR is necessary to prov
Hahnfeld added a reviewer: beanz.
Hahnfeld added a comment.
SGTM, I don't see any drawback
Comment at: cmake/Modules/CompilerRTUtils.cmake:200
@@ -199,5 +199,3 @@
string(REGEX REPLACE "[ \t]*[\r\n]+[ \t]*" ";" CONFIG_OUTPUT
${CONFIG_OUTPUT})
- list(GET CONFIG_OUTPUT 0 LLVM_
mgorny added inline comments.
Comment at: cmake/Modules/CompilerRTUtils.cmake:200
@@ -199,5 +199,3 @@
string(REGEX REPLACE "[ \t]*[\r\n]+[ \t]*" ";" CONFIG_OUTPUT
${CONFIG_OUTPUT})
- list(GET CONFIG_OUTPUT 0 LLVM_BINARY_DIR)
- list(GET CONFIG_OUTPUT 1 LLVM_TOOLS_BINARY_DIR)
beanz accepted this revision.
beanz added a comment.
This revision is now accepted and ready to land.
One comment below, otherwise LGTM.
Comment at: cmake/Modules/CompilerRTUtils.cmake:200
@@ -199,5 +199,3 @@
string(REGEX REPLACE "[ \t]*[\r\n]+[ \t]*" ";" CONFIG_OUTPUT
${CON
mgorny updated this revision to Diff 71040.
Herald added subscribers: mgorny, beanz.
https://reviews.llvm.org/D24005
Files:
cmake/Modules/CompilerRTUtils.cmake
Index: cmake/Modules/CompilerRTUtils.cmake
===
--- cmake/Modules/Compi
mgorny marked 3 inline comments as done.
mgorny added a comment.
And done.
https://reviews.llvm.org/D24005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Hahnfeld added a comment.
In https://reviews.llvm.org/D24005#540200, @mgorny wrote:
> And done.
I think @beanz meant to actually do the renames for consistency... Sorry for
the confusion!
https://reviews.llvm.org/D24005
___
cfe-commits mailing l
mgorny added a comment.
In https://reviews.llvm.org/D24005#540803, @Hahnfeld wrote:
> In https://reviews.llvm.org/D24005#540200, @mgorny wrote:
>
> > And done.
>
>
> I think @beanz meant to actually do the renames for consistency... Sorry for
> the confusion!
I know but I feel like it's a topi
beanz added a comment.
You cannot rename the variables that start with `LLVM_*`, but the variables
without the leading `LLVM` can be renamed to whatever makes sense, or left
as-is. I'm fine with either way.
The variables starting with `LLVM_*` are effectively public interface to the
build syst
This revision was automatically updated to reflect the committed changes.
Closed by commit rL281461: [cmake] Support overriding llvm-config query results
(authored by mgorny).
Changed prior to commit:
https://reviews.llvm.org/D24005?vs=71040&id=71348#toc
Repository:
rL LLVM
https://reviews.
mgorny added a comment.
Thanks again. I've left them as-is and committed.
Repository:
rL LLVM
https://reviews.llvm.org/D24005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
11 matches
Mail list logo