This revision was automatically updated to reflect the committed changes.
hokein marked an inline comment as done.
Closed by commit rL280824: [include-fixer] Support finding headers for the
symbol under cursor. (authored by hokein).
Changed prior to commit:
https://reviews.llvm.org/D24075?vs=70
massberg added a comment.
The Emacs part looks good for me now.
Comment at: include-fixer/tool/clang-include-fixer.el:204
@@ -197,3 +203,3 @@
(message (concat "Calling the include fixer. "
"This might take some seconds. Please wait."))
Then it f
hokein marked an inline comment as done.
Comment at: include-fixer/tool/clang-include-fixer.el:204
@@ -197,3 +203,3 @@
(message (concat "Calling the include fixer. "
"This might take some seconds. Please wait."))
massberg wrote:
> Is this message
hokein updated this revision to Diff 70545.
hokein marked an inline comment as done.
hokein updated the summary for this revision.
hokein added a comment.
bool => boolean
https://reviews.llvm.org/D24075
Files:
include-fixer/find-all-symbols/SymbolInfo.h
include-fixer/tool/ClangIncludeFixer.
massberg added a comment.
Added two comments. It took some time for me to recall Emacs Lisps ;)
Comment at: include-fixer/tool/clang-include-fixer.el:48
@@ +47,3 @@
+ :group 'clang-include-fixer
+ :type 'bool
+ :risky t)
Please use 'boolean here
hokein added a comment.
+ Jens for reviewing emacs integration part.
https://reviews.llvm.org/D24075
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
bkramer accepted this revision.
bkramer added a comment.
This revision is now accepted and ready to land.
I can't really comment on the emacs integration with my limited knowledge of
elisp. The rest looks good to me.
https://reviews.llvm.org/D24075
___
