shafik added a comment.
Herald added subscribers: ChuanqiXu, arphaman.
Herald added a project: All.
Is this PR still relevant or should it just be closed?
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D24439/new/
https://reviews.llvm.org/D24439
Eugene.Zelenko updated this revision to Diff 71063.
Eugene.Zelenko added a comment.
Implement Saleem suggestions.
Repository:
rL LLVM
https://reviews.llvm.org/D24439
Files:
lib/Analysis/PrintfFormatString.cpp
lib/Basic/Diagnostic.cpp
lib/Basic/SourceManager.cpp
Eugene.Zelenko marked 3 inline comments as done.
Eugene.Zelenko added a comment.
Repository:
rL LLVM
https://reviews.llvm.org/D24439
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Prazek added a subscriber: Prazek.
Prazek accepted this revision.
Prazek added a reviewer: Prazek.
Prazek added a comment.
This revision is now accepted and ready to land.
Lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D24439
___
cfe-commits
compnerd added inline comments.
Comment at: lib/Basic/SourceManager.cpp:395
@@ -383,2 +394,3 @@
+ for (llvm::DenseMap::iterator
I = FileInfos.begin(), E = FileInfos.end(); I != E; ++I) {
if (I->second) {
Cant this be rewritten as:
for (const
Eugene.Zelenko created this revision.
Eugene.Zelenko added reviewers: mehdi_amini, compnerd.
Eugene.Zelenko added a subscriber: cfe-commits.
Eugene.Zelenko set the repository for this revision to rL LLVM.
I checked this patch on my own build on RHEL 6. Regressions were OK.
Repository:
rL LLVM
