Re: [PATCH] D24484: [analyzer] Fix ExprEngine::VisitMemberExpr

2016-09-13 Thread Alexander Shaposhnikov via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL281373: [analyzer] Fix ExprEngine::VisitMemberExpr (authored by alexshap). Changed prior to commit: https://reviews.llvm.org/D24484?vs=71082=71218#toc Repository: rL LLVM

Re: [PATCH] D24484: [analyzer] Fix ExprEngine::VisitMemberExpr

2016-09-13 Thread Alexander Shaposhnikov via cfe-commits
alexshap added a comment. Thx, I do. Repository: rL LLVM https://reviews.llvm.org/D24484 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D24484: [analyzer] Fix ExprEngine::VisitMemberExpr

2016-09-13 Thread Anna Zaks via cfe-commits
zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thanks! Do you have commit access? Repository: rL LLVM https://reviews.llvm.org/D24484 ___ cfe-commits mailing list

Re: [PATCH] D24484: [analyzer] Fix ExprEngine::VisitMemberExpr

2016-09-13 Thread Alexander Shaposhnikov via cfe-commits
alexshap added inline comments. Comment at: test/Analysis/array-struct.c:147 @@ +146,3 @@ + bar(((gets3().a))); +} + compnerd wrote: > Perhaps Im missing something, but theres no change to actually verify the > output? without the changes the analyzer is

Re: [PATCH] D24484: [analyzer] Fix ExprEngine::VisitMemberExpr

2016-09-13 Thread Saleem Abdulrasool via cfe-commits
compnerd added inline comments. Comment at: test/Analysis/array-struct.c:147 @@ +146,3 @@ + bar(((gets3().a))); +} + Perhaps Im missing something, but theres no change to actually verify the output? Repository: rL LLVM https://reviews.llvm.org/D24484

Re: [PATCH] D24484: [analyzer] Fix ExprEngine::VisitMemberExpr

2016-09-12 Thread Alexander Shaposhnikov via cfe-commits
alexshap added a comment. 1. For the code: struct TestBufferStruct { int Buffer[3]; }; struct TestBufferStruct GetTestBufferStruct() { struct TestBufferStruct a; return a; } void AcceptPointer(int *a) { } void TestFunc() {

[PATCH] D24484: [analyzer] Fix ExprEngine::VisitMemberExpr

2016-09-12 Thread Alexander Shaposhnikov via cfe-commits
alexshap created this revision. alexshap added reviewers: NoQ, bcraig, zaks.anna. alexshap added a subscriber: cfe-commits. alexshap set the repository for this revision to rL LLVM. alexshap changed the visibility of this Differential Revision from "Public (No Login Required)" to "All Users".