This revision was automatically updated to reflect the committed changes.
Closed by commit rL281921: Replace __ANDROID__ with __BIONIC__. (authored by
danalbert).
Changed prior to commit:
https://reviews.llvm.org/D24690?vs=71714=71852#toc
Repository:
rL LLVM
https://reviews.llvm.org/D24690
danalbert added inline comments.
Comment at: include/__config:90
@@ +89,3 @@
+#if defined(__linux__)
+#include
+#if !defined(__GLIBC_PREREQ)
EricWF wrote:
> Does MUSL libc have a `features.h`? This include was previously guarded by
> if
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM after addressing the MUSL libc comment.
Comment at: include/__config:90
@@ +89,3 @@
+#if defined(__linux__)
+#include
+#if !defined(__GLIBC_PREREQ)
danalbert added a comment.
In https://reviews.llvm.org/D24690#545523, @compnerd wrote:
> So, the only thing that Im confused about is where does `__BIONIC__` get
> defined?
It's in Bionic's ``, which gets pulled in via ``.
Comment at: include/__config:340
@@ -339,3 +344,1
EricWF added inline comments.
Comment at: include/__config:340
@@ -339,3 +344,1 @@
#if !defined(_LIBCPP_HAS_MUSL_LIBC)
-# include
-#if __GLIBC_PREREQ(2, 15)
What happened to this include? I believe it's needed to get `__GLIBC_PREREQ`.
Repository:
rL LLVM
compnerd added a subscriber: compnerd.
compnerd added a comment.
So, the only thing that Im confused about is where does `__BIONIC__` get
defined?
Comment at: include/__config:766
@@ -761,3 +765,3 @@
// Most unix variants have catopen. These are the specific ones that don't.
danalbert created this revision.
danalbert added reviewers: EricWF, mclow.lists.
danalbert added a subscriber: cfe-commits.
danalbert set the repository for this revision to rL LLVM.
Herald added subscribers: srhines, danalbert, tberghammer.
None of these checks are specific to Android devices.
