djasper closed this revision.
djasper added a comment.
Submitted as r294179. Sorry I missed this before.
https://reviews.llvm.org/D24703
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
daphnediane added a comment.
ping. I've been using this for a long time and still seems to apply to cleanly
and works, though the line numbers have shifted a little since I generated the
previous diff.
https://reviews.llvm.org/D24703
___
daphnediane added a comment.
ping.
FYI I have found some additional similar cases when
AlignConsecutiveDeclarations is also true, that I'll see if I can document/test
case etc. at some point.
https://reviews.llvm.org/D24703
___
cfe-commits
Eugene.Zelenko added a comment.
Looks like patch was not committed.
https://reviews.llvm.org/D24703
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
daphnediane added a comment.
In https://reviews.llvm.org/D24703#545917, @djasper wrote:
> Looks good. Thank you!
Thanks. Are there additional steps I need to get it commited or do I just wait
for a commiter to notice?
https://reviews.llvm.org/D24703
daphnediane updated this revision to Diff 71767.
daphnediane added a comment.
Adds test case, changes to suggested fix allowing break after template opener
that is not immediately followed by template closer.
https://reviews.llvm.org/D24703
Files:
lib/Format/TokenAnnotator.cpp
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
Looks good. Thank you!
https://reviews.llvm.org/D24703
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
daphnediane created this revision.
daphnediane added a reviewer: djasper.
daphnediane added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
Fix for the formatting options combination of BreakBeforeBinaryOperators: All,
AlignAfterOpenBracket: AlwaysBreak not handling long templates
djasper added a comment.
I think, this is the wrong fix. Instead, a
|| (Left.is(TT_TemplateOpener) && !Right.is(TT_TemplateCloser))
should be added to the last return statement of this function.
Also, could you please add a test in unittests/Format/FormatTest.cpp.
