[PATCH] D24812: Lit C++11 Compatibility Patch #11

This revision was automatically updated to reflect the committed changes. Closed by commit rL295484: [Test] Make Lit tests C++11 compatible - misc (authored by lcharles). Changed prior to commit: https://reviews.llvm.org/D24812?vs=88617=88961#toc Repository: rL LLVM

[PATCH] D24812: Lit C++11 Compatibility Patch #11

rjmccall added a comment. In https://reviews.llvm.org/D24812#678931, @tigerleapgorge wrote: > @rjmccall > > Hi John, I've made the changes to volatile.cpp. > I take it this patch is good for commit? Yes, I think I have the information I wanted from Reid. LGTM.

[PATCH] D24812: Lit C++11 Compatibility Patch #11

rjmccall added inline comments. Comment at: test/CodeGenCXX/static-init.cpp:14 +// CHECK98: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global %"struct.test4::HasVTable" zeroinitializer, comdat, align 8 +// CHECK11: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global

[PATCH] D24812: Lit C++11 Compatibility Patch #11

tigerleapgorge added a comment. @rjmccall Hi John, I've made the changes to volatile.cpp. I take it this patch is good for commit? https://reviews.llvm.org/D24812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D24812: Lit C++11 Compatibility Patch #11

tigerleapgorge updated this revision to Diff 88617. tigerleapgorge added a comment. Changed "CHECK11" to "CHECK11-NEXT". https://reviews.llvm.org/D24812 Files: test/CodeGenCXX/mangle-unnamed.cpp test/CodeGenCXX/static-init.cpp test/CodeGenCXX/volatile-1.cpp test/CodeGenCXX/volatile.cpp

[PATCH] D24812: Lit C++11 Compatibility Patch #11

rnk added inline comments. Comment at: test/CodeGenCXX/static-init.cpp:14 +// CHECK98: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global %"struct.test4::HasVTable" zeroinitializer, comdat, align 8 +// CHECK11: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global {

[PATCH] D24812: Lit C++11 Compatibility Patch #11

rjmccall added a reviewer: rnk. rjmccall added a comment. Generally looks good to me, thanks. One question for Reid. Comment at: test/CodeGenCXX/static-init.cpp:14 +// CHECK98: @_ZZN5test414useStaticLocalEvE3obj = linkonce_odr global %"struct.test4::HasVTable"

[PATCH] D24812: Lit C++11 Compatibility Patch #11

tigerleapgorge updated this revision to Diff 88224. tigerleapgorge edited the summary of this revision. tigerleapgorge added a comment. Remove another 3 tests reviewed in https://reviews.llvm.org/D29859 https://reviews.llvm.org/D24812 Files: test/CodeGenCXX/mangle-unnamed.cpp

[PATCH] D24812: Lit C++11 Compatibility Patch #11

probinson added a reviewer: rjmccall. probinson added a comment. +rjmccall as CodeGen owner. https://reviews.llvm.org/D24812 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D24812: Lit C++11 Compatibility Patch #11

tigerleapgorge updated this revision to Diff 86923. tigerleapgorge added a comment. Revise again, https://reviews.llvm.org/D28425 fixed 7 tests. r290229 fixed 1 test. Down to 8 tests. https://reviews.llvm.org/D24812 Files: test/CodeGenCXX/linetable-cleanup.cpp

[PATCH] D24812: Lit C++11 Compatibility Patch #11

tigerleapgorge updated the summary for this revision. tigerleapgorge updated this revision to Diff 81987. tigerleapgorge added a comment. Update Lit patch #11 to match latest Clang behavior 2 minor changes in this update 1. Back out test/CodeGenCXX/mangle-unnamed.cpp because it has already

[PATCH] D24812: Lit C++11 Compatibility Patch #11

tigerleapgorge created this revision. tigerleapgorge added a reviewer: rsmith. tigerleapgorge added a subscriber: cfe-commits. Herald added a subscriber: aemerson. Hi Everyone, Here is the 11th Lit C++11 compatibility patch. This will most likely be my final Lit patch. I have updated 16 tests