rmaprath added a comment.
In https://reviews.llvm.org/D24864#570924, @vitalybuka wrote:
> So there is:
>
> - Looking for __cxa_thread_atexit_impl in c
> - Looking for __cxa_thread_atexit_impl in c - not found
>
> and libcxx is configured with -DLIBCXX_ENABLE_THREADS=OFF
I think, the problem h
vitalybuka added a comment.
Maybe?
- if (UNIX AND NOT (APPLE OR CYGWIN))
+ if (LIBCXXABI_ENABLE_THREADS AND UNIX AND NOT (APPLE OR CYGWIN))
list(APPEND LIBCXXABI_SOURCES cxa_thread_atexit.cpp)
endif()
https://reviews.llvm.org/D24864
___
cfe-co
rmaprath added a comment.
In https://reviews.llvm.org/D24864#570935, @vitalybuka wrote:
> Maybe?
>
> - if (UNIX AND NOT (APPLE OR CYGWIN))
> + if (LIBCXXABI_ENABLE_THREADS AND UNIX AND NOT (APPLE OR CYGWIN))
> list(APPEND LIBCXXABI_SOURCES cxa_thread_atexit.cpp)
> endif()
>
Yes!
I was
vitalybuka added a comment.
Thanks, done https://reviews.llvm.org/D25636
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added a comment.
In https://reviews.llvm.org/D24864#570954, @vitalybuka wrote:
> Thanks, done https://reviews.llvm.org/D25636
Thanks for the fix!
/ Asiri
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
cfe-commits@lists.llv
rmaprath created this revision.
rmaprath added reviewers: EricWF, mclow.lists, jroelofs, compnerd.
rmaprath added a subscriber: cfe-commits.
This is simply a cleanup of D18482 (patch taken with permission) while adapting
it to match what we have already implemented for libcxx.
Note that I haven'
rmaprath added a comment.
Sigh. I've bumped into some downstream problems. Will commit as soon as I've
verified these problems are not related to the patch.
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
htt
rmaprath updated this revision to Diff 74519.
rmaprath added a comment.
Herald added a subscriber: modocache.
Patch re-based on the latest trunk.
I've resolved my downstream issues, will be committing soon.
/ Asiri
https://reviews.llvm.org/D24864
Files:
CMakeLists.txt
src/config.h
src/c
rmaprath closed this revision.
rmaprath added a comment.
Committed as r284128.
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka added a comment.
This change breaks
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/25625/steps/build%2032-bit%20symbolizer%20for%20compiler_rt_build/logs/stdio
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
vitalybuka added a comment.
So there is:
- Looking for __cxa_thread_atexit_impl in c
- Looking for __cxa_thread_atexit_impl in c - not found
and libcxx is configured with -DLIBCXX_ENABLE_THREADS=OFF
https://reviews.llvm.org/D24864
___
cfe-commits
rmaprath updated this revision to Diff 72478.
rmaprath added a comment.
Use `__internal_linkage__` attribute to control visibility following
https://reviews.llvm.org/D24642.
https://reviews.llvm.org/D24864
Files:
include/__cxxabi_config.h
src/config.h
src/cxa_exception.cpp
src/cxa_exce
compnerd added inline comments.
Comment at: src/config.h:41
@@ +40,3 @@
+defined(__CloudABI__) || \
+defined(__sun__)
+# define _LIBCXXABI_HAS_THREAD_API_PTHREAD
Can you change this to `defined(__sun__) && defined(_POSIX_THREADS)` at the
very least? The
EricWF added a comment.
LGTM other than the inline comments. I'll give it a final once over tonight or
tomorrow.
Comment at: include/__cxxabi_config.h:36
@@ -35,1 +35,3 @@
#endif
+ #if defined(_MSC_VER) && !defined(__clang__)
+ // Using Microsoft Visual C++ compiler
rmaprath added inline comments.
Comment at: src/config.h:22
@@ +21,3 @@
+
+#if defined(__GNUC__) || defined(__clang__)
+#define _LIBCXXABI_PRAGMA(_parameter_) _Pragma(#_parameter_)
EricWF wrote:
> What's the point of defining `_LIBCXXABI_WARNING`? It's unused and
rmaprath updated this revision to Diff 72653.
rmaprath added a comment.
Herald added subscribers: mgorny, beanz.
Address review comments from @compnerd and @EricWF.
https://reviews.llvm.org/D24864
Files:
CMakeLists.txt
src/config.h
src/cxa_exception.cpp
src/cxa_exception_storage.cpp
s
rmaprath added a comment.
@EricWF: Gentle ping.
https://reviews.llvm.org/D24864
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
EricWF accepted this revision.
EricWF added a comment.
This revision is now accepted and ready to land.
LGTM once the `_POSIX_THREADS` comment is addressed.
Comment at: src/config.h:46
@@ +45,3 @@
+defined(__linux__) || \
+defined(__APPLE__) || \
+defined(__CloudABI_
18 matches
Mail list logo
