Re: [PATCH] D24881: [clang-tidy] Cleaning up language options.

2016-09-23 Thread Alexander Kornienko via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. Thank you for the cleanup! Please clang-format-diff the files before submitting. Otherwise looks good. Repository: rL LLVM https://reviews.llvm.org/D24881

Re: [PATCH] D24881: [clang-tidy] Cleaning up language options.

2016-09-23 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a comment. I think it's reasonable to compile code in C++11 with minimal changes (only modernize-replace-auto-ptr is really needed) and test it before further modernization. Repository: rL LLVM https://reviews.llvm.org/D24881

Re: [PATCH] D24881: [clang-tidy] Cleaning up language options.

2016-09-23 Thread Gábor Horváth via cfe-commits
xazax.hun added a comment. In https://reviews.llvm.org/D24881#551487, @Eugene.Zelenko wrote: > I think will be good idea to enable modernize-loop-convert, > modernize-use-auto, modernize-use-default, modernize-use-nullptr only in > C++11 mode. > > Probably modernize-avoid-bind code code be

Re: [PATCH] D24881: [clang-tidy] Cleaning up language options.

2016-09-23 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko added a subscriber: Eugene.Zelenko. Eugene.Zelenko added a comment. I think will be good idea to enable modernize-loop-convert, modernize-use-auto, modernize-use-default, modernize-use-nullptr only in C++11 mode. Probably modernize-avoid-bind code code be simplified too.

[PATCH] D24881: [clang-tidy] Cleaning up language options.

2016-09-23 Thread Gábor Horváth via cfe-commits
xazax.hun created this revision. xazax.hun added reviewers: hokein, alexfh. xazax.hun added a subscriber: cfe-commits. xazax.hun set the repository for this revision to rL LLVM. xazax.hun added a project: clang-tools-extra. Herald added a subscriber: nemanjai. In some cases do not register the