This revision was automatically updated to reflect the committed changes.
Closed by commit rL283680: [CUDA] Support and std::min/max on the
device. (authored by jlebar).
Changed prior to commit:
https://reviews.llvm.org/D24979?vs=72719=74053#toc
Repository:
rL LLVM
jlebar updated this revision to Diff 72719.
jlebar added a comment.
Herald added a subscriber: mehdi_amini.
s/libgcc/runtime/
https://reviews.llvm.org/D24979
Files:
clang/lib/Driver/ToolChains.cpp
clang/lib/Headers/CMakeLists.txt
clang/lib/Headers/__clang_cuda_complex_builtins.h
echristo accepted this revision.
echristo added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D24979#554378, @jlebar wrote:
> > I' personally would prefer to force-include these files. I suspect it will
> > not change things much as we already include a
jlebar added a comment.
> I' personally would prefer to force-include these files. I suspect it will
> not change things much as we already include a lot.
We have already had bugs filed by users whose root cause was that we #included
more things than nvcc #includes. I know exact
tra added a subscriber: echristo.
tra added a comment.
This looks like fix-includes and it may be somewhat shaky if users start
messing with include paths. You may want to get @echristo's input on that. I'
personally would prefer to force-include these files. I suspect it will not
change
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added subscribers: cfe-commits, jhen.
Herald added subscribers: mgorny, beanz.
We do this by wrapping and .
Tests are in the test-suite. support to come separately.
https://reviews.llvm.org/D24979
Files:
