This revision was automatically updated to reflect the committed changes.
Closed by commit rL285585: [x86][inline-asm] Add support for curly brackets
escape using "%" in extended… (authored by mzuckerm).
Changed prior to commit:
https://reviews.llvm.org/D25012?vs=73602&id=76415#toc
Repository:
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Repository:
rL LLVM
https://reviews.llvm.org/D25012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailm
mharoush added a comment.
Done
Repository:
rL LLVM
https://reviews.llvm.org/D25012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mharoush marked an inline comment as done.
mharoush added a comment.
Done
Repository:
rL LLVM
https://reviews.llvm.org/D25012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mharoush updated this revision to Diff 73602.
Repository:
rL LLVM
https://reviews.llvm.org/D25012
Files:
lib/AST/Stmt.cpp
test/CodeGen/x86_inlineasm_curly_bracket_escape.c
Index: lib/AST/Stmt.cpp
===
--- lib/AST/Stmt.cpp
+++
rnk added inline comments.
> x86_inlineasm_curly_bracket_escape.c:1
> +// RUN: %clang_cc1 %s -target-cpu skylake-avx512 -O0 -S -o - -Wall -Werror
> | FileCheck %s
> +// This test checks validity of inline assembly using curly brackets syntax
Please check the LLVM IR, not the assembly
Reposito
mharoush created this revision.
mharoush added reviewers: rnk, myatsina.
mharoush added a subscriber: cfe-commits.
mharoush set the repository for this revision to rL LLVM.
This patch is a compatibility fix for clang, matching GCC support for charter
escape when using extended in-line assembly (i
