This revision was automatically updated to reflect the committed changes.
Closed by commit rL285591: [x86][inline-asm][AVX512][llvm][PART-2] (authored by
mzuckerm).
Changed prior to commit:
https://reviews.llvm.org/D25062?vs=75278=76429#toc
Repository:
rL LLVM
mharoush removed rL LLVM as the repository for this revision.
mharoush updated this revision to Diff 75278.
mharoush added a comment.
Added LLVM_FALLTHROUGH
https://reviews.llvm.org/D25062
Files:
lib/Target/X86/X86ISelLowering.cpp
Index: lib/Target/X86/X86ISelLowering.cpp
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
Comment at: lib/Target/X86/X86ISelLowering.cpp:32315
+}
+ // Else fall through (handle "Y" constraint).
case 'v':
Use LLVM_FALLTHROUGH here to avoid
mharoush updated this revision to Diff 75005.
mharoush added a comment.
Added default case, minor ws style.
Repository:
rL LLVM
https://reviews.llvm.org/D25062
Files:
lib/Target/X86/X86ISelLowering.cpp
Index: lib/Target/X86/X86ISelLowering.cpp
mharoush updated this revision to Diff 74986.
mharoush added a comment.
Herald added a subscriber: mehdi_amini.
fixed Reids comments
Repository:
rL LLVM
https://reviews.llvm.org/D25062
Files:
lib/Target/X86/X86ISelLowering.cpp
Index: lib/Target/X86/X86ISelLowering.cpp
rnk added a comment.
Looks good functionally with some surface level nits
> X86ISelLowering.cpp:31979
>break;
> }
>}
Let's check size 2 after size 1, it seems more logical, and is 1 is probably
the common case.
> X86ISelLowering.cpp:32025
>case 'Y':
> +// Impliment