shafik added a comment.
Herald added a project: All.
Is this still relevant or should this be closed?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D25171/new/
https://reviews.llvm.org/D25171
___
cfe-commits mailing list
cfe-commits@lists.llvm
rsmmr added a comment.
Well, last time I counted it was more like 100 contributors---Bro existed
before GitHub (and before git). The style-guide is lacking, yes ... what can I
say.
I don't really want to argue about importance of the project. We would like to
use clang-format here and elsewher
djasper added a comment.
It's not about whether or not we like the patch. It's whether adding these
options is a good trade-off for clang-format overall. If we find that actually
more people would find these styles desirable, we can reconsider.
I have left some comments anyway in case you want
djasper added a comment.
Sorry, but that's actually not enough, at least at first sight. With 37
contributors total, bro is still quite small and only 12 of them have more than
a handful of commits. And it doesn't have a real style guide. It has:
https://www.bro.org/development/contribute.html#
rsmmr added a comment.
Sure, I'm aiming to use clang-format on a couple of open-source code bases
using this style, with the main one being the Bro network security monitor, see
www.bro.org and github.com/bro/bro (note the stars and forks :-) Bro is also
featured on GitHub's list of security sh
rsmmr added a comment.
Cool, thanks Steve. What's the next step for me to get it committed?
https://reviews.llvm.org/D25171
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
djasper added a comment.
Could you read:
http://clang.llvm.org/docs/ClangFormatStyleOptions.html#adding-additional-style-options
And provide some evidence about the requirements for new style options?
https://reviews.llvm.org/D25171
___
cfe-commits
elsteveogrande accepted this revision.
elsteveogrande added a reviewer: elsteveogrande.
elsteveogrande added a comment.
This revision is now accepted and ready to land.
Thought I'd take a look at the list of diffs and take a stab at a few (a few
easy-looking and short ones :) ) to unblock some pp
rsmmr created this revision.
rsmmr added reviewers: djasper, lodato.
rsmmr added a subscriber: cfe-commits.
Herald added a subscriber: klimek.
This patch adds two new options, feedback welcome.
SpacesAroundConditions (bool)
If true, spaces will be inserted around if/for/while conditions.
Spac
