GorNishanov abandoned this revision.
GorNishanov added a comment.
I'll simplify and split it into super tiny microscopic patches to have a better
chance of being reviewed.
https://reviews.llvm.org/D25258
___
cfe-commits mailing list
GorNishanov added a comment.
friendly ping
https://reviews.llvm.org/D25258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GorNishanov added a comment.
friendly ping
https://reviews.llvm.org/D25258
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
GorNishanov updated this revision to Diff 73835.
GorNishanov added a comment.
Addressed review comments. Anything else, @rsmith?
1. compute default new align and pass it to coro.id
2. fix typo in comment
https://reviews.llvm.org/D25258
Files:
include/clang/AST/StmtCXX.h
GorNishanov added inline comments.
> majnemer wrote in CGCoroutine.cpp:68-69
> I think that's just `CGM.getContext().getTargetInfo().getSuitableAlign() /
> CGM.getContext().getTargetInfo().getCharWidth()`
Yay! One less FIXME.
I think I will make it to match __STDCPP_DEFAULT_NEW_ALIGNMENT__:
majnemer added inline comments.
> CGCoroutine.cpp:68-69
> +void CodeGenFunction::EmitCoroutineBody(const CoroutineBodyStmt ) {
> + auto *NullPtr = llvm::ConstantPointerNull::get(Builder.getInt8PtrTy());
> + // FIXME: Instead of 0, pass an equivalent of alignas(maxalign_t).
> + auto *CoroId =
GorNishanov created this revision.
GorNishanov added reviewers: rsmith, EricWF.
GorNishanov added a subscriber: cfe-commits.
Herald added a subscriber: mehdi_amini.
1. Sema: Add allocation / deallocation substatements.
2. Sema: Add labels to final-suspend and deallocation substatements.
3. Sema:
