[PATCH] D25353: Implement __emul, __emulu, _mul128 and _umul128 MS intrinsics

2016-10-10 Thread Eugene Zelenko via cfe-commits
Eugene.Zelenko closed this revision. Eugene.Zelenko added a comment. Committed in rL283785. https://reviews.llvm.org/D25353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D25353: Implement __emul, __emulu, _mul128 and _umul128 MS intrinsics

2016-10-10 Thread Albert Gutowski via cfe-commits
agutowski updated this revision to Diff 74147. agutowski added a comment. address comments https://reviews.llvm.org/D25353 Files: include/clang/Basic/BuiltinsX86.def include/clang/Basic/BuiltinsX86_64.def lib/CodeGen/CGBuiltin.cpp lib/Headers/intrin.h test/CodeGen/ms-intrinsics.c

[PATCH] D25353: Implement __emul, __emulu, _mul128 and _umul128 MS intrinsics

2016-10-10 Thread Hans Wennborg via cfe-commits
hans accepted this revision. hans added a comment. This revision is now accepted and ready to land. lgtm with some nits Comment at: lib/CodeGen/CGBuiltin.cpp:7592 Value *LHS = EmitScalarExpr(E->getArg(0)); Value *RHS = EmitScalarExpr(E->getArg(1)); llvm::Type