This revision was automatically updated to reflect the committed changes.
Closed by commit rL284232: [libcxx] Do not declare the thread api when
__external_threading is present (authored by asiri).
Changed prior to commit:
https://reviews.llvm.org/D25468?vs=74234&id=74668#toc
Repository:
rL
rmaprath added a comment.
@EricWF: Gentle ping.
https://reviews.llvm.org/D25468
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rmaprath added a comment.
Added some comments to @EricWF's feedback. Will check back tomorrow (falling
asleep...)
/ Asiri
Comment at: include/__threading_support:25
// redundancy is intentional.
#if defined(_LIBCPP_HAS_THREAD_API_EXTERNAL)
#if !defined(__clang__) && (_GNUC
EricWF added inline comments.
Comment at: include/__threading_support:25
// redundancy is intentional.
#if defined(_LIBCPP_HAS_THREAD_API_EXTERNAL)
#if !defined(__clang__) && (_GNUC_VER < 500)
If `_LIBCPP_HAS_THREAD_API_EXTERNAL` is defined can't we just assum
rmaprath created this revision.
rmaprath added a reviewer: EricWF.
rmaprath added a subscriber: cfe-commits.
This fixes a small omission where even when `__external_threading` is provided,
we attempt to declare a pthread based threading API. Instead, we should leave
out everything for the `__ext
