This revision was automatically updated to reflect the committed changes.
Closed by commit rL296584: [Sema] Add variable captured by a block to the
enclosing lambda's (authored by ahatanak).
Changed prior to commit:
https://reviews.llvm.org/D25556?vs=86918=90123#toc
Repository:
rL LLVM
rjmccall added a comment.
Well, I was hoping that Richard would weigh in, but absent that, I don't have
any objections. Since it fixes a known bug, let's just go ahead and do it.
LGTM.
https://reviews.llvm.org/D25556
___
cfe-commits mailing
ahatanak updated this revision to Diff 86918.
ahatanak added a comment.
Rebase
https://reviews.llvm.org/D25556
Files:
include/clang/Sema/Sema.h
lib/Sema/Sema.cpp
lib/Sema/SemaExpr.cpp
test/SemaObjCXX/blocks.mm
Index: test/SemaObjCXX/blocks.mm
malcolm.parsons resigned from this revision.
malcolm.parsons added a comment.
I don't see anything wrong with this, but I don't think I'm qualified to
approve it.
https://reviews.llvm.org/D25556
___
cfe-commits mailing list
ahatanak added reviewers: ABataev, malcolm.parsons.
ahatanak added a comment.
Add a few more people who have looked at this part of clang in the past to the
reviewers list.
https://reviews.llvm.org/D25556
___
cfe-commits mailing list
ahatanak added a comment.
ping
https://reviews.llvm.org/D25556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ahatanak updated this revision to Diff 82394.
ahatanak added a comment.
Rebase.
r286584 changed getCurLambda to optionally skip CapturedRegionScopeInfos. This
patch changes it to skip BlockScopeInfos too.
https://reviews.llvm.org/D25556
Files:
include/clang/Sema/Sema.h
lib/Sema/Sema.cpp
ahatanak updated this revision to Diff 75956.
ahatanak added a comment.
Add the variable to the list of potential captures only if it's declared
outside of the lambda expression. I don't think we need to check that the
variable is declared outside of the lambda because
rjmccall added a comment.
In https://reviews.llvm.org/D25556#572054, @ahatanak wrote:
> In https://reviews.llvm.org/D25556#569809, @rjmccall wrote:
>
> > Richard should probably weigh in about whether we should be recording
> > potential captures at *all* capturing scopes. But at the very
ahatanak added a comment.
In https://reviews.llvm.org/D25556#569809, @rjmccall wrote:
> Richard should probably weigh in about whether we should be recording
> potential captures at *all* capturing scopes. But at the very least, I think
> you have a bug here where the variable is declared
ahatanak created this revision.
ahatanak added reviewers: rsmith, rjmccall.
ahatanak added a subscriber: cfe-commits.
When compiling the following code, DoMarkVarDeclReferenced fails to capture
variable "outerp":
auto lambda =[&](auto p) {
return ^{
return p + outerp;
}();
};
11 matches
Mail list logo