This revision was automatically updated to reflect the committed changes.
Closed by commit rL284219: Deduplicate sets of replacements by file names.
(authored by ioeric).
Changed prior to commit:
https://reviews.llvm.org/D25565?vs=74634&id=74636#toc
Repository:
rL LLVM
https://reviews.llvm.
ioeric updated this revision to Diff 74634.
ioeric added a comment.
- Merge branch 'master' of http://llvm.org/git/clang into arcpatch-D25565
- Forgot to update names in tests...
https://reviews.llvm.org/D25565
Files:
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactorin
ioeric updated this revision to Diff 74632.
ioeric added a comment.
- Change name to groupReplacementsByFile
https://reviews.llvm.org/D25565
Files:
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactoring.h
lib/Tooling/Core/Replacement.cpp
lib/Tooling/Refactoring.cpp
djasper accepted this revision.
djasper added a comment.
This revision is now accepted and ready to land.
I'd not rename the function. Otherwise looks good.
https://reviews.llvm.org/D25565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
ioeric added inline comments.
Comment at: include/clang/Tooling/Core/Replacement.h:233
- Replacements mergeReplacements(const ReplacementsImpl &Second) const;
-
This is dead code.
https://reviews.llvm.org/D25565
___
ioeric updated this revision to Diff 74531.
ioeric added a comment.
- Updated comments for RefactoringTool.
https://reviews.llvm.org/D25565
Files:
include/clang/Tooling/Core/Replacement.h
include/clang/Tooling/Refactoring.h
lib/Tooling/Core/Replacement.cpp
lib/Tooling/Refactoring.cpp
ioeric created this revision.
ioeric added a reviewer: djasper.
ioeric added subscribers: cfe-commits, bkramer, hokein.
Herald added a subscriber: klimek.
If there are multiple pairs with the same file
path after removing dots, we only keep one pair (with path after dots being
removed) and discar
