mstorsjo added a comment.
> (should they be also on AArch64? I had problems with testing it for AArch64,
> so I left it)
Technically, I think they should be on AArch64 as well. But clang/LLVM probably
doesn't support AArch64/Windows yet (I guess?), so testing it probably is
impossible. When/if
rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.
lgtm
https://reviews.llvm.org/D25576
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
agutowski updated this revision to Diff 74586.
agutowski added a comment.
make target-independent Interlocked builtins use EmitMSVCBuiltinExpr
https://reviews.llvm.org/D25576
Files:
include/clang/Basic/BuiltinsARM.def
include/clang/Basic/BuiltinsX86_64.def
lib/CodeGen/CGBuiltin.cpp
lib/
rnk added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:2730
+llvm::AtomicOrdering::SequentiallyConsistent);
+return Builder.CreateSub(RMWI, ConstantInt::get(IntTy, 1));
}
agutowski wrote:
> rnk wrote:
> > Can you make a helper similar to
agutowski added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:2730
+llvm::AtomicOrdering::SequentiallyConsistent);
+return Builder.CreateSub(RMWI, ConstantInt::get(IntTy, 1));
}
rnk wrote:
> Can you make a helper similar to MakeBinaryAtomi
rnk added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:2730
+llvm::AtomicOrdering::SequentiallyConsistent);
+return Builder.CreateSub(RMWI, ConstantInt::get(IntTy, 1));
}
Can you make a helper similar to MakeBinaryAtomicValue for inc/dec
agutowski created this revision.
agutowski added reviewers: rnk, hans, majnemer, mstorsjo.
agutowski added a subscriber: cfe-commits.
Herald added a subscriber: aemerson.
Previously global 64-bit versions of _Interlocked functions broke buildbots on
i386, so now I'm adding them as builtins for x8
