[PATCH] D25621: DebugInfo: use DIAlignment type.

2016-10-17 Thread Victor Leschuk via cfe-commits
vleschuk updated this revision to Diff 74899. vleschuk added a comment. - Use uint32_t directly for alignment instead of creating typedef ofr it - Get rid of DebugInfo dependency in AST https://reviews.llvm.org/D25621 Files: include/clang/AST/ASTContext.h include/clang/AST/DeclBase.h

[PATCH] D25621: DebugInfo: use DIAlignment type.

2016-10-17 Thread Victor Leschuk via cfe-commits
vleschuk marked an inline comment as done. vleschuk added inline comments. Comment at: include/clang/AST/ASTContext.h:83 uint64_t Width; -unsigned Align; +llvm::DIAlignment Align; bool AlignIsRequired : 1; vleschuk wrote: > aprantl wrote: > >

Re: [PATCH] D25621: DebugInfo: use DIAlignment type.

2016-10-17 Thread David Blaikie via cfe-commits
On Mon, Oct 17, 2016 at 4:37 AM Victor Leschuk wrote: > vleschuk marked an inline comment as done. > vleschuk added inline comments. > > > > Comment at: include/clang/AST/ASTContext.h:83 > uint64_t Width; > -unsigned Align; > +

[PATCH] D25621: DebugInfo: use DIAlignment type.

2016-10-17 Thread Victor Leschuk via cfe-commits
vleschuk marked an inline comment as done. vleschuk added inline comments. Comment at: include/clang/AST/ASTContext.h:83 uint64_t Width; -unsigned Align; +llvm::DIAlignment Align; bool AlignIsRequired : 1; aprantl wrote: > I'm not sure we want

[PATCH] D25621: DebugInfo: use DIAlignment type.

2016-10-14 Thread Adrian Prantl via cfe-commits
aprantl added inline comments. Comment at: include/clang/AST/ASTContext.h:83 uint64_t Width; -unsigned Align; +llvm::DIAlignment Align; bool AlignIsRequired : 1; I'm not sure we want to use a debug info type inside the AST. I think we only

[PATCH] D25621: DebugInfo: use DIAlignment type.

2016-10-14 Thread Victor Leschuk via cfe-commits
vleschuk created this revision. vleschuk added reviewers: aprantl, mehdi_amini, dblaikie, echristo. vleschuk added a subscriber: cfe-commits. Use DIAlignment type introduced in https://reviews.llvm.org/D25620 https://reviews.llvm.org/D25621 Files: include/clang/AST/ASTContext.h