vleschuk updated this revision to Diff 74899.
vleschuk added a comment.
- Use uint32_t directly for alignment instead of creating typedef ofr it
- Get rid of DebugInfo dependency in AST
https://reviews.llvm.org/D25621
Files:
include/clang/AST/ASTContext.h
include/clang/AST/DeclBase.h
vleschuk marked an inline comment as done.
vleschuk added inline comments.
Comment at: include/clang/AST/ASTContext.h:83
uint64_t Width;
-unsigned Align;
+llvm::DIAlignment Align;
bool AlignIsRequired : 1;
vleschuk wrote:
> aprantl wrote:
> >
On Mon, Oct 17, 2016 at 4:37 AM Victor Leschuk
wrote:
> vleschuk marked an inline comment as done.
> vleschuk added inline comments.
>
>
>
> Comment at: include/clang/AST/ASTContext.h:83
> uint64_t Width;
> -unsigned Align;
> +
vleschuk marked an inline comment as done.
vleschuk added inline comments.
Comment at: include/clang/AST/ASTContext.h:83
uint64_t Width;
-unsigned Align;
+llvm::DIAlignment Align;
bool AlignIsRequired : 1;
aprantl wrote:
> I'm not sure we want
aprantl added inline comments.
Comment at: include/clang/AST/ASTContext.h:83
uint64_t Width;
-unsigned Align;
+llvm::DIAlignment Align;
bool AlignIsRequired : 1;
I'm not sure we want to use a debug info type inside the AST. I think we only
vleschuk created this revision.
vleschuk added reviewers: aprantl, mehdi_amini, dblaikie, echristo.
vleschuk added a subscriber: cfe-commits.
Use DIAlignment type introduced in https://reviews.llvm.org/D25620
https://reviews.llvm.org/D25621
Files:
include/clang/AST/ASTContext.h