mgorny retitled this revision from "[Driver] Support "hardfloat" vendor triples
used by Gentoo" to "[Driver] Improve support for Gentoo arm*-hardfloat-*-*eabi
triples".
mgorny updated the summary for this revision.
mgorny added a reviewer: atanasyan.
mgorny updated this revision to Diff 80118.
h
rengolin added a reviewer: compnerd.
rengolin added inline comments.
Comment at: lib/Driver/ToolChains.cpp:1674
TripleAliases.append(begin(ARMHFTriples), end(ARMHFTriples));
+} else if (TargetTriple.getEnvironment() == llvm::Triple::MuslEABIHF) {
+ TripleAliases.a
mgorny added inline comments.
Comment at: lib/Driver/ToolChains.cpp:1674
TripleAliases.append(begin(ARMHFTriples), end(ARMHFTriples));
+} else if (TargetTriple.getEnvironment() == llvm::Triple::MuslEABIHF) {
+ TripleAliases.append(begin(ARMHFMuslTriples), end(ARMH
rengolin added inline comments.
Comment at: lib/Driver/ToolChains.cpp:1674
TripleAliases.append(begin(ARMHFTriples), end(ARMHFTriples));
+} else if (TargetTriple.getEnvironment() == llvm::Triple::MuslEABIHF) {
+ TripleAliases.append(begin(ARMHFMuslTriples), end(AR
mgorny added inline comments.
Comment at: test/Driver/linux-ld.c:1016
+// CHECK-LD-GENTOO-ARMHF: "-dynamic-linker" "/lib/ld-linux-armhf.so.3"
+// CHECK-LD-GENTOO-ARMHF:
"{{.*}}/usr/lib/gcc/armv7a-hardfloat-linux-gnueabi/4.9.3/crtbegin.o"
+// CHECK-LD-GENTOO-ARMHF:
"-L[[SYSROOT]
rengolin added inline comments.
Comment at: test/Driver/linux-ld.c:1016
+// CHECK-LD-GENTOO-ARMHF: "-dynamic-linker" "/lib/ld-linux-armhf.so.3"
+// CHECK-LD-GENTOO-ARMHF:
"{{.*}}/usr/lib/gcc/armv7a-hardfloat-linux-gnueabi/4.9.3/crtbegin.o"
+// CHECK-LD-GENTOO-ARMHF:
"-L[[SYSROO
compnerd added a comment.
Please don't canonicalize the triple that way. The behavior of
`armv7-unknown-linux-gnueabi` is different from `armv7-unknown-linux-gnueabihf`
which is different from `armv7-unknown-linux-gnueabihf -mfloat-abi=hard`. I
agree that this is absolutely terrible and unexp
mgorny added a comment.
How should I proceed, then? Was something along the lines of the earlier diff a
better idea?
https://reviews.llvm.org/D25686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listi
rengolin added a comment.
I think this patch should move to canonicalise the triple as per all the
others, in the right place (vendor/environment).
If you find `hardfloat` or on where the vendor should be, and there are no
other possible vendors, just append `hf` to the environment and mark the
mgorny added a comment.
In https://reviews.llvm.org/D25686#614420, @rengolin wrote:
> I think this patch should move to canonicalise the triple as per all the
> others, in the right place (vendor/environment).
>
> If you find `hardfloat` or on where the vendor should be, and there are no
> othe
rengolin added a comment.
We already massage the triple in many cases, and what goes into IR is not
always the same as what is used in Clang.
Examples are x86_64's "x32" extension to the ABI, ARM -> Thumb triples, adding
compulsory dashes and unknowns (ex. x86_64--linux-gnu), etc.
You just hav
mgorny abandoned this revision.
mgorny added a comment.
I give up. I'm just going to complain to Gentoo ARM people a lot and maybe
they'll fix their triples.
https://reviews.llvm.org/D25686
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
12 matches
Mail list logo
