[PATCH] D26082: Support for Python 3 in libclang python bindings

2017-01-13 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe added a comment. I've reverted this change and submitted https://reviews.llvm.org/D28682 to explicitly check the Python version. I'll pick this up again, I do want Python 3 support. Repository: rL LLVM https://reviews.llvm.org/D26082 ___

[PATCH] D26082: Support for Python 3 in libclang python bindings

2017-01-13 Thread Mathieu Duponchelle via Phabricator via cfe-commits
MathieuDuponchelle added a comment. In https://reviews.llvm.org/D26082#645361, @jbcoe wrote: > I've reverted this change and submitted https://reviews.llvm.org/D28682 to > explicitly check the Python version. > > I'll pick this up again, I do want Python 3 support. I'm not entirely sure why yo

[PATCH] D26082: Support for Python 3 in libclang python bindings

2016-12-14 Thread Mathieu Duponchelle via Phabricator via cfe-commits
MathieuDuponchelle added a comment. Hey, I'm on Linux, Fedora 23 to be specific. Repository: rL LLVM https://reviews.llvm.org/D26082 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[PATCH] D26082: Support for Python 3 in libclang python bindings

2017-01-11 Thread Mathieu Duponchelle via Phabricator via cfe-commits
MathieuDuponchelle added a comment. In https://reviews.llvm.org/D26082#621496, @jbcoe wrote: > Hi Mathieu, > What platform did you run the tests on? How did you run them? I don't get > any failures when running tests on macOS 10.12.1. Hey @jbcoe, do you think you can have a look at this issue

[PATCH] D26082: Support for Python 3 in libclang python bindings

2017-01-11 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe added a comment. @MathieuDuponchelle I'm still keen to get to the bottom of this failure. I've not had time to reproduce it yet. I'm thankful for you taking a look at this and reporting the issue. We need to get this working well for everyone. Repository: rL LLVM https://reviews.llvm

[PATCH] D26082: Support for Python 3 in libclang python bindings

2017-01-12 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe added a comment. @MathieuDuponchelle I've set up a docker image with Fedora 23 and reproduced the errors as you reported. I've no immediate idea what the problem might be. Might be worth looking with address-sanitizer. Repository: rL LLVM https://reviews.llvm.org/D26082 __

[PATCH] D26082: Support for Python 3 in libclang python bindings

2017-01-12 Thread Mathieu Duponchelle via Phabricator via cfe-commits
MathieuDuponchelle added a comment. In https://reviews.llvm.org/D26082#644402, @jbcoe wrote: > @MathieuDuponchelle I've set up a docker image with Fedora 23 and reproduced > the errors as you reported. > > I've no immediate idea what the problem might be. Might be worth looking with > address-s

[PATCH] D26082: Support for Python 3 in libclang python bindings

2017-01-13 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe added a comment. Sadly I can't run valgrind on macOS Sierra. I'll try and look at the effects of bindings/python/clang/cindex.py L181 in more detail today. Just out of curiosity, will you be using the Python 3 bindings for anything? If so what? Repository: rL LLVM https://reviews.ll

[PATCH] D26082: Support for Python 3 in libclang python bindings

2016-11-27 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe added a comment. Thanks Mathieu. Tests ran without issues when I submitted my patch but I tested on macOS. I'll have a look into this and see if I can reproduce the problem. Repository: rL LLVM https://reviews.llvm.org/D26082 ___ cfe-comm

[PATCH] D26082: Support for Python 3 in libclang python bindings

2016-11-27 Thread Mathieu Duponchelle via Phabricator via cfe-commits
MathieuDuponchelle added a comment. Hey, for what it's worth when skipping the free at this line: https://github.com/llvm-mirror/clang/blob/master/bindings/python/clang/cindex.py#L181 the issues are gone, I haven't investigated the reason why. Repository: rL LLVM https://reviews.llvm.org/D2

[PATCH] D26082: Support for Python 3 in libclang python bindings

2016-11-28 Thread Mathieu Duponchelle via cfe-commits
MathieuDuponchelle added a comment. I get tons of errors when running these tests with python 3 (version 3.4.3) with a fresh build of clang and llvm. The number of failures vs errors vary wildly between each invocation, the number of total failures + errors stays the same, which led me to think

[PATCH] D26082: Support for Python 3 in libclang python bindings

2016-12-13 Thread Jonathan B Coe via Phabricator via cfe-commits
jbcoe added a comment. Hi Mathieu, What platform did you run the tests on? How did you run them? I don't get any failures when running tests on macOS 10.12.1. command: `env PYTHONPATH=`pwd` LD_LIBRARY_PATH=/Users/jon/DEV/LLVM/build-ninja/lib nosetests-3.4 .` python: Python 3.5.2 (default, Oct

[PATCH] D26082: Support for Python 3 in libclang python bindings

2016-10-30 Thread Jonathan B Coe via cfe-commits
jbcoe retitled this revision from "Incomplete support for Python 3 in libclang python bindings" to "Support for Python 3 in libclang python bindings". jbcoe updated the summary for this revision. jbcoe updated this revision to Diff 76338. jbcoe added a comment. Python bindings tests now pass in P

[PATCH] D26082: Support for Python 3 in libclang python bindings

2016-10-30 Thread Jonathan B Coe via cfe-commits
jbcoe removed rL LLVM as the repository for this revision. jbcoe updated this revision to Diff 76344. jbcoe added a comment. Remove mistakenly committed debugging output. https://reviews.llvm.org/D26082 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_translation_uni

[PATCH] D26082: Support for Python 3 in libclang python bindings

2016-11-02 Thread Saleem Abdulrasool via cfe-commits
compnerd accepted this revision. compnerd added a comment. This revision is now accepted and ready to land. It would be nice if there is a simple way to handle the possible performance impact for python 2. Worst case, we can deal with it when it becomes an issue. Comment at:

[PATCH] D26082: Support for Python 3 in libclang python bindings

2016-11-02 Thread Michał Górny via cfe-commits
mgorny added a comment. A few comments/questions. However, please note that those are generic Python comments and I haven't used or tested the clang Python API yet. Comment at: bindings/python/clang/cindex.py:77 +# Python 3 strings are unicode, translate them to/from utf8 for

[PATCH] D26082: Support for Python 3 in libclang python bindings

2016-11-02 Thread Jonathan B Coe via cfe-commits
jbcoe updated this revision to Diff 76774. jbcoe marked an inline comment as done. jbcoe added a comment. Respond to review comments. https://reviews.llvm.org/D26082 Files: bindings/python/clang/cindex.py bindings/python/tests/cindex/test_translation_unit.py Index: bindings/python/tests/ci

[PATCH] D26082: Support for Python 3 in libclang python bindings

2016-11-02 Thread Jonathan B Coe via cfe-commits
jbcoe added inline comments. Comment at: bindings/python/clang/cindex.py:77 +# Python 3 strings are unicode, translate them to/from utf8 for C-interop +if type(u"") == str: +class c_string_p(c_char_p): mgorny wrote: > What is the Python3 version you're aiming

[PATCH] D26082: Support for Python 3 in libclang python bindings

2016-11-03 Thread Jonathan B Coe via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL285909: Support for Python 3 in libclang python bindings (authored by jbcoe). Changed prior to commit: https://reviews.llvm.org/D26082?vs=76774&id=76854#toc Repository: rL LLVM https://reviews.llvm.