This revision was automatically updated to reflect the committed changes.
Closed by commit rL286424: [clang-tidy] Do not issue fix for functions that are
referenced outside of… (authored by flx).
Changed prior to commit:
https://reviews.llvm.org/D26203?vs=77343&id=77430#toc
Repository:
rL LL
flx marked an inline comment as done.
flx added a comment.
Thanks for the review!
https://reviews.llvm.org/D26203
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
flx removed rL LLVM as the repository for this revision.
flx updated this revision to Diff 77343.
https://reviews.llvm.org/D26203
Files:
clang-tidy/performance/UnnecessaryValueParamCheck.cpp
test/clang-tidy/performance-unnecessary-value-param.cpp
Index: test/clang-tidy/performance-unnecessa
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from a commenting nit, LGTM.
Comment at: clang-tidy/performance/UnnecessaryValueParamCheck.cpp:130
+ // Do not propose fixes when:
+ // 1. in macros sin
flx created this revision.
flx added reviewers: alexfh, sbenza.
flx added a subscriber: cfe-commits.
flx set the repository for this revision to rL LLVM.
Suppress fixes for functions that are referenced within the compilation unit
outside of a call expression as the signature change could break t
