[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

aaron.ballman added a comment. While I agree that there's an issue here that needs to be solved, I don't think this patch will be merged as-is -- there are technical issues brought up by @alexfh that have not been addressed, and I share the opinion that we should extend existing suppression

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

davidsj2 added a comment. I too am interested in this patch. In addition to the use cases already described, this would be helpful for projects that use several different static analysis tools and don't want to clutter code with a bunch of different suppression comments to satisfy each tool.

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

vlebourl added a comment. Very interested in this one as well! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D26418/new/ https://reviews.llvm.org/D26418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

khoroshansky added a comment. Herald added a subscriber: danielkiss. Will this ever be merged? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D26418/new/ https://reviews.llvm.org/D26418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

okainov added a comment. Any updates on this one? That sounds so fundamental feature which current version is lacking, it's very frustrating it was not merged yet... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D26418/new/ https://reviews.llvm.org/D26418

Re: [PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

> On Jan 30, 2018, at 7:50 AM, Andrew Peter Marlow via Phabricator via > cfe-commits wrote: > > marlowa added a comment. > > In https://reviews.llvm.org/D26418#653146, @nkakuev wrote: > >> Ping. > > > another ping. I am desperate for this enhancement and am

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

marlowa added a comment. In https://reviews.llvm.org/D26418#653146, @nkakuev wrote: > Ping. another ping. I am desperate for this enhancement and am really glad that nkakuev has done all the hard development work. I am currently being nobbled in my use of clang-tidy because the project is

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

alexfh added a comment. Adding a mechanism to supply suppression lists would be useful as long as it's flexible and extensible enough and doesn't significantly affect performance (especially, when not in use). In particular, it shouldn't be bound to a specific format or a specific way to store

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

nkakuev added a comment. Thanks for the response, Alex! The problem I tried to address in this patch was that notes in source files were "unsuppressing" warnings from third-party headers (this is what we were discussing in https://reviews.llvm.org/D26418#590417). But at this point, I no

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

alexfh added a comment. My apologies again for the delay. There are a few things I'm concerned about: 1. Suppression list being a command-line option is going to be inconvenient to completely useless in many setups. The `-line-filter` option is special in this regard, since it was added for a

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

nkakuev added a comment. Ping. https://reviews.llvm.org/D26418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

alexfh added a comment. Sorry for the delay. I'll try to get back to this patch soon. https://reviews.llvm.org/D26418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

nkakuev added a comment. Ping. Ignoring note locations is a coarse-grained solution that will suppress both false and //true// positives. Suppress-checks-filter is a finer-grained instrument that can be targetted on particular false positives precisely. My sympathies are with

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

malcolm.parsons resigned from this revision. malcolm.parsons removed a reviewer: malcolm.parsons. malcolm.parsons added a comment. In https://reviews.llvm.org/D26418#590476, @nkakuev wrote: > On a second thought, ignoring note locations might be a good enough solution > for me. > How should I

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

nkakuev added a comment. In https://reviews.llvm.org/D26418#590417, @malcolm.parsons wrote: > In https://reviews.llvm.org/D26418#590383, @nkakuev wrote: > > > The warning is caused by a third-party code, but header filter won't help > > you to suppress it since it now relates to your sources. >

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

nkakuev added a comment. In https://reviews.llvm.org/D26418#590417, @malcolm.parsons wrote: > In https://reviews.llvm.org/D26418#590383, @nkakuev wrote: > > > The warning is caused by a third-party code, but header filter won't help > > you to suppress it since it now relates to your sources. >

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

alexfh added a comment. I also don't understand the use case for turning off only some checks for third-party headers. Either you care about third-party stuff or not, why only switch off certain checks? https://reviews.llvm.org/D26418 ___

[PATCH] D26418: [clang-tidy] Add '-suppress-checks-filter' option to suppress diagnostics from certain files

Eugene.Zelenko added a comment. I think will be good idea to mention this in documentation and release notes. https://reviews.llvm.org/D26418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org