Re: [PATCH] D26422: Revert "Define __ANDROID_API__ for all Android builds."

Yes, some bots don't build all the targets. I think the test should go into Preprocessor/init.c. On Tue, Nov 8, 2016 at 2:07 PM, Stephen Hines wrote: > srhines added a comment. > > Reverted because this broke builds: > > clang-hexagon-elf >

[PATCH] D26422: Revert "Define __ANDROID_API__ for all Android builds."

srhines added a comment. Reverted because this broke builds: clang-hexagon-elf llvm-clang-lld-x86_64-scei-ps4-ubuntu-fast clang-ppc64be-linux-multistage llvm-clang-lld-x86_64-scei-ps4-windows10pro-fast It isn't clear from the logs why these builds failed, since I did a general build, but

[PATCH] D26422: Revert "Define __ANDROID_API__ for all Android builds."

This revision was automatically updated to reflect the committed changes. Closed by commit rL286298: Revert "Define __ANDROID_API__ for all Android builds." (authored by srhines). Changed prior to commit: https://reviews.llvm.org/D26422?vs=77254=77256#toc Repository: rL LLVM

[PATCH] D26422: Revert "Define __ANDROID_API__ for all Android builds."

srhines created this revision. srhines added subscribers: danalbert, eugenis, pirama, cfe-commits. Herald added a subscriber: tberghammer. This reverts commit a8804ddd9fe71304b28e5b834d134fe93e568ee0. https://reviews.llvm.org/D26422 Files: lib/Basic/Targets.cpp