malcolm.parsons added a comment.
https://reviews.llvm.org/D28022 changes performance-unnecessary-value-param so
that it handles this part of modernize-pass-by-value.
So this isn't the end of the story here yet.
Comment at:
clang-tools-extra/trunk/test/clang-tidy/misc-move-con
alexfh added a comment.
LG.
In https://reviews.llvm.org/D26453#592934, @flx wrote:
> In https://reviews.llvm.org/D26453#590720, @malcolm.parsons wrote:
>
> > Add ValuesOnly option to modernize-pass-by-value.
>
>
> Thanks for doing this. Alex, would this work for us?
Yep, I think so.
===
This revision was automatically updated to reflect the committed changes.
Closed by commit rL290051: [clang-tidy] Remove duplicated check from
move-constructor-init (authored by malcolm.parsons).
Changed prior to commit:
https://reviews.llvm.org/D26453?vs=78867&id=81849#toc
Repository:
rL LL
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM!
https://reviews.llvm.org/D26453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26453#610668, @malcolm.parsons wrote:
> In https://reviews.llvm.org/D26453#592934, @flx wrote:
>
> > In https://reviews.llvm.org/D26453#590720, @malcolm.parsons wrote:
> >
> > > Add ValuesOnly option to modernize-pass-by-value.
> >
> >
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26453#592934, @flx wrote:
> In https://reviews.llvm.org/D26453#590720, @malcolm.parsons wrote:
>
> > Add ValuesOnly option to modernize-pass-by-value.
>
>
> Thanks for doing this. Alex, would this work for us?
ping.
https://reviews
malcolm.parsons updated this revision to Diff 78867.
malcolm.parsons added a comment.
Mention in release notes.
https://reviews.llvm.org/D26453
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/misc/MoveConstructorInitCheck.cpp
clang-tidy/misc/MoveConstructorInitCheck.h
clang-tidy/mo
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26453#596254, @aaron.ballman wrote:
> (This part of the check is one half modernization, one half performance, and
> one half correctness, depending on which lens you view the code through.)
The performance part should be handled by
aaron.ballman added a comment.
I think this meets my needs for the cert-oop11-cpp check as it appears to be
preserving the original behavior. If a user has the `UseCERTSemantics` option
set in one of their scripts, that appears to be silently accepted and discarded
currently, so I don't think t
flx added a comment.
In https://reviews.llvm.org/D26453#590720, @malcolm.parsons wrote:
> Add ValuesOnly option to modernize-pass-by-value.
Thanks for doing this. Alex, would this work for us?
https://reviews.llvm.org/D26453
___
cfe-commits maili
malcolm.parsons updated this revision to Diff 77456.
malcolm.parsons added a comment.
Store new option.
https://reviews.llvm.org/D26453
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/misc/MoveConstructorInitCheck.cpp
clang-tidy/misc/MoveConstructorInitCheck.h
clang-tidy/modernize/
malcolm.parsons updated this revision to Diff 77371.
malcolm.parsons updated the summary for this revision.
malcolm.parsons added a comment.
Add ValuesOnly option to modernize-pass-by-value.
https://reviews.llvm.org/D26453
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/misc/MoveConstr
malcolm.parsons updated this revision to Diff 77358.
malcolm.parsons added a comment.
Update comment in performance-unnecessary-value-param check.
https://reviews.llvm.org/D26453
Files:
clang-tidy/cert/CERTTidyModule.cpp
clang-tidy/misc/MoveConstructorInitCheck.cpp
clang-tidy/misc/MoveCon
malcolm.parsons added a comment.
In https://reviews.llvm.org/D26453#590636, @flx wrote:
> Is the modernize-pass-by-value check configurable in a way to only trigger
> when copied constructor arguments are not moved?
No; good idea.
https://reviews.llvm.org/D26453
__
flx added a comment.
Is the modernize-pass-by-value check configurable in a way to only trigger when
copied constructor arguments are not moved?
I think our use case has been to have move-constructor-init check enabled to
catch cases that can be optimized but not trigger on every constructor th
malcolm.parsons created this revision.
malcolm.parsons added reviewers: aaron.ballman, alexfh, flx.
malcolm.parsons added a subscriber: cfe-commits.
An addition to the move-constructor-init check was duplicating the
modernize-pass-by-value check.
Remove the additional check and UseCERTSemantics op
16 matches
Mail list logo
