This revision was automatically updated to reflect the committed changes.
Closed by commit rL286669: Tread TSan LLVM flags to driver: add TSan
controlling flags to clang. (authored by eugenis).
Changed prior to commit:
https://reviews.llvm.org/D26461?vs=77667&id=77683#toc
Repository:
rL LLVM
alekseyshl added a comment.
PTAL
https://reviews.llvm.org/D26461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alekseyshl updated this revision to Diff 77667.
alekseyshl added a comment.
- Remove unnecessary flag qualifications.
https://reviews.llvm.org/D26461
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
lib/Driver/SanitizerArgs.cpp
test/Driver/fsanitize.c
Index:
alekseyshl marked an inline comment as done.
alekseyshl added a comment.
.
https://reviews.llvm.org/D26461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alekseyshl updated this revision to Diff 77649.
alekseyshl added a comment.
- Add FIXME to address the rest of the suggestions later.
https://reviews.llvm.org/D26461
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
lib/Driver/SanitizerArgs.cpp
test/Driver/fsan
pcc added inline comments.
Comment at: include/clang/Driver/Options.td:732
+def fsanitize_thread_memory_access : Flag<["-"],
"fsanitize-thread-memory-access">,
+ Group, Flags<[CC1Option]>,
+ HelpText<"Enable
eugenis accepted this revision.
eugenis added a comment.
LGTM
https://reviews.llvm.org/D26461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alekseyshl marked an inline comment as done.
alekseyshl added a comment.
Frontend options removed.
https://reviews.llvm.org/D26461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alekseyshl updated this revision to Diff 77647.
alekseyshl added a comment.
- Remove unnecessary frontend options.
https://reviews.llvm.org/D26461
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
lib/Driver/SanitizerArgs.cpp
test/Driver/fsanitize.c
Index: tes
eugenis added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:732
Args.hasArg(OPT_fsanitize_coverage_trace_pc_guard);
+ Opts.SanitizeThreadMemoryAccess =
+ Args.hasFlag(OPT_fsanitize_thread_memory_access,
It looks like lib/Frontend c
pcc accepted this revision.
pcc added a reviewer: pcc.
pcc added a comment.
Seems like a reasonable enough first step. Please add a FIXME to pass these
flags as attributes.
https://reviews.llvm.org/D26461
___
cfe-commits mailing list
cfe-commits@li
alekseyshl updated this revision to Diff 77631.
alekseyshl added a comment.
- Translate new driver flags to legacy -llvm ones.
https://reviews.llvm.org/D26461
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
include/clang/Frontend/CodeGenOptions.def
lib/Driver
alekseyshl added inline comments.
Comment at: test/Driver/fsanitize.c:288
+// RUN: %clang -target x86_64-linux-gnu -fsanitize=thread
-fsanitize-thread-data-races -fno-sanitize-thread-data-races %s -### 2>&1 |
FileCheck %s --check-prefix=CHECK-TSAN-DATA-RACES-OFF
+// CHECK-TSAN-
alekseyshl updated this revision to Diff 77432.
alekseyshl marked 2 inline comments as done.
alekseyshl added a comment.
- Rename new options to better reflect their functionality.
https://reviews.llvm.org/D26461
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
dvyukov added inline comments.
Comment at: include/clang/Driver/Options.td:733
+ Group, Flags<[CC1Option]>,
+ HelpText<"Enable data race detection in
ThreadSanitizer">;
+def fno_sanitize_thread_data_races : Flag<[
eugenis added inline comments.
Comment at: test/Driver/fsanitize.c:288
+// RUN: %clang -target x86_64-linux-gnu -fsanitize=thread
-fsanitize-thread-data-races -fno-sanitize-thread-data-races %s -### 2>&1 |
FileCheck %s --check-prefix=CHECK-TSAN-DATA-RACES-OFF
+// CHECK-TSAN-DAT
alekseyshl updated this revision to Diff 77398.
alekseyshl added a comment.
- Added ust test for the new command line args.
https://reviews.llvm.org/D26461
Files:
include/clang/Driver/Options.td
include/clang/Driver/SanitizerArgs.h
include/clang/Frontend/CodeGenOptions.def
lib/CodeGen/B
eugenis added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:735
+ OPT_fno_sanitize_thread_data_races,
+ Opts.SanitizeThreadDataRaces);
+ Opts.SanitizeThreadStackTraces =
alekseyshl wrote:
> eugenis wrote:
>
alekseyshl added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:735
+ OPT_fno_sanitize_thread_data_races,
+ Opts.SanitizeThreadDataRaces);
+ Opts.SanitizeThreadStackTraces =
eugenis wrote:
> It seems common t
eugenis added a comment.
Oh, and this needs a test. See test/Driver/fsanitize.c (search for
-fsanitize-address-use-after-scope as an example).
https://reviews.llvm.org/D26461
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm
eugenis added inline comments.
Comment at: lib/Frontend/CompilerInvocation.cpp:735
+ OPT_fno_sanitize_thread_data_races,
+ Opts.SanitizeThreadDataRaces);
+ Opts.SanitizeThreadStackTraces =
It seems common to hardcode the defau
alekseyshl created this revision.
alekseyshl added a reviewer: eugenis.
alekseyshl added a subscriber: cfe-commits.
New clang flags, all default to true:
-f[no-]sanitize-thread-data-races
-f[no-]sanitize-thread-stack-traces
-f[no-]sanitize-thread-atomics
https://reviews.llvm.org/D26461
Files:
22 matches
Mail list logo
