ogoffart marked an inline comment as done.
ogoffart added a comment.
In https://reviews.llvm.org/D26465#607860, @arphaman wrote:
> What did you test the parsing on? Will this patch get similar improvements
> for code that compiles without errors and warnings?
It was benchamerked with https://g
ogoffart updated this revision to Diff 82325.
ogoffart marked an inline comment as done.
https://reviews.llvm.org/D26465
Files:
include/clang/Basic/Diagnostic.h
include/clang/Basic/DiagnosticIDs.h
lib/Basic/Diagnostic.cpp
lib/Basic/DiagnosticIDs.cpp
lib/Serialization/ASTReader.cpp
Inde
ogoffart added a comment.
ping?
https://reviews.llvm.org/D26465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ogoffart added a comment.
Ping 2
https://reviews.llvm.org/D26465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added a comment.
Is there any way to test this change?
> This saves more than 5% of the parsing time according to perf.
That sounds great. What did you test the parsing on? Will this patch get
similar improvements for code that compiles without errors and warnings?
ogoffart created this revision.
ogoffart added reviewers: cfe-commits, rsmith.
Herald added a subscriber: sanjoy.
DiagnosticIDs::getDiagnosticSeverity function turns out to take a lot of time
in getDecomposedLoc. It is called quite often from different places. (For
example from Sema::CheckTempla
