Anastasia closed this revision.
Anastasia added a comment.
Committed in r286849.
https://reviews.llvm.org/D26509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Anastasia updated the summary for this revision.
Anastasia updated this revision to Diff 77825.
Anastasia added a comment.
1. Corrected typos in CodeGen test.
2. Improved description.
https://reviews.llvm.org/D26509
Files:
include/clang/Basic/DiagnosticSemaKinds.td
lib/CodeGen/CGBuiltin.cpp
yaxunl accepted this revision.
yaxunl added a comment.
This revision is now accepted and ready to land.
LGTM with the change for the summary. Thanks!
https://reviews.llvm.org/D26509
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://list
Anastasia added a comment.
I see. If I say something like:
- For the number of event argument allow to pass larger integers than 32 bits
as soon as compiler can prove that the range fits in 32 bits. If not, the
diagnostic will be given.
- Change type of the arguments specifying sizes of the co
yaxunl added a comment.
I thought the number of events was also changed to size_t type. Now I
understand. Probably I was misled by the summary:
"Parameters representing number of events as well as sizes of enqueued block
arguments in enqueue_kernel function are specified as uint type. This prev
Anastasia added inline comments.
Comment at: lib/CodeGen/CGBuiltin.cpp:2547
+ llvm::Value *NumEvents =
+ Builder.CreateZExtOrTrunc(EmitScalarExpr(E->getArg(3)), Int32Ty);
llvm::Value *EventList =
yaxunl wrote:
> should Int32Ty be SizeTy?
I am
yaxunl added a comment.
My main concern is that by making the number of event be of type size_t instead
of uint we are not conforming to the spec, although I agree it is better for
the user.
Comment at: lib/CodeGen/CGBuiltin.cpp:2547
+ llvm::Value *NumEvents =
+
Anastasia created this revision.
Anastasia added a reviewer: yaxunl.
Anastasia added a subscriber: cfe-commits.
Parameters representing number of events as well as sizes of enqueued block
arguments in enqueue_kernel function are specified as uint type. This prevents
passing sizeof(int) type expr
