[PATCH] D26540: [Sema] Accept and ignore the leaf attribute

2016-11-15 Thread Aaron Ballman via cfe-commits
aaron.ballman added a comment. In https://reviews.llvm.org/D26540#593433, @phosek wrote: > That makes sense for diagnostics, but this attribute is only an optimization > hint, so compiler should be allowed to ignore it. I can take a look how > difficult it'd be to actually implement this attrib

[PATCH] D26540: [Sema] Accept and ignore the leaf attribute

2016-11-11 Thread Petr Hosek via cfe-commits
phosek added a comment. That makes sense for diagnostics, but this attribute is only an optimization hint, so compiler should be allowed to ignore it. I can take a look how difficult it'd be to actually implement this attribute, but I don't think it's Sema-only attribute. I don't know if there'

[PATCH] D26540: [Sema] Accept and ignore the leaf attribute

2016-11-11 Thread Nico Weber via cfe-commits
thakis added a comment. (Maybe implementing real support isn't so difficult? From a quick glance, it sounds like this is a sema-only attribute?) Repository: rL LLVM https://reviews.llvm.org/D26540 ___ cfe-commits mailing list cfe-commits@lists.l

[PATCH] D26540: [Sema] Accept and ignore the leaf attribute

2016-11-11 Thread Aaron Ballman via cfe-commits
aaron.ballman added a reviewer: aaron.ballman. aaron.ballman added a comment. There are a *lot* of attributes GCC supports that Clang does not, and we generally do not silence diagnostics with them as that usually does the user a disservice because they are unaware that the attribute has no effe

[PATCH] D26540: [Sema] Accept and ignore the leaf attribute

2016-11-10 Thread Petr Hosek via cfe-commits
phosek created this revision. phosek added a subscriber: cfe-commits. phosek set the repository for this revision to rL LLVM. This is a GCC extension, Clang should accept the attribute without a warning for compatibility with GCC. https://llvm.org/bugs/show_bug.cgi?id=30980 Repository: rL LL