[PATCH] D26794: [OpenCL] Blocks are allowed to capture arrays in OpenCL 2.0 and higher.

2017-04-10 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added inline comments. Comment at: lib/Sema/SemaExpr.cpp:13645 // Blocks are not allowed to capture arrays. + if (!S.getLangOpts().OpenCL && CaptureType->isArrayType()) { I think the comment should be updated. Comment at:

[PATCH] D26794: [OpenCL] Blocks are allowed to capture arrays in OpenCL 2.0 and higher.

2017-04-07 Thread Egor Churaev via Phabricator via cfe-commits
echuraev updated this revision to Diff 94503. echuraev marked an inline comment as done. https://reviews.llvm.org/D26794 Files: lib/Sema/SemaExpr.cpp test/SemaOpenCL/blocks_with_array.cl Index: test/SemaOpenCL/blocks_with_array.cl

[PATCH] D26794: [OpenCL] Blocks are allowed to capture arrays in OpenCL 2.0 and higher.

2017-04-07 Thread Egor Churaev via Phabricator via cfe-commits
echuraev added a comment. Yes, I have an access to the new revision and I have read it. https://reviews.llvm.org/D26794 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26794: [OpenCL] Blocks are allowed to capture arrays in OpenCL 2.0 and higher.

2017-04-06 Thread Anastasia Stulova via Phabricator via cfe-commits
Anastasia added a comment. In https://reviews.llvm.org/D26794#598784, @Anastasia wrote: > I have created a bug to Khronos regarding this, but unfortunately I don't see > it being progressed yet. > https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15659 > > The problem here is that I am not sure

[PATCH] D26794: [OpenCL] Blocks are allowed to capture arrays in OpenCL 2.0 and higher.

2016-11-17 Thread Anastasia Stulova via cfe-commits
Anastasia added a comment. I have created a bug to Khronos regarding this, but unfortunately I don't see it being progressed yet. https://cvs.khronos.org/bugzilla/show_bug.cgi?id=15659 The problem here is that I am not sure we should deviate from the ObjC implementation because OpenCL blocks ar

[PATCH] D26794: [OpenCL] Blocks are allowed to capture arrays in OpenCL 2.0 and higher.

2016-11-17 Thread Egor Churaev via cfe-commits
echuraev created this revision. echuraev added a reviewer: Anastasia. echuraev added subscribers: cfe-commits, yaxunl, bader. https://reviews.llvm.org/D26794 Files: lib/Sema/SemaExpr.cpp test/SemaOpenCL/blocks_with_arrays.cl Index: test/SemaOpenCL/blocks_with_arrays.cl =