[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-12-29 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF closed this revision. EricWF added a comment. Committed on behalf of @AntonBikineev in r290744. https://reviews.llvm.org/D26829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-17 Thread Anton Bikineev via cfe-commits
AntonBikineev created this revision. AntonBikineev added reviewers: mclow.lists, rsmith, cfe-commits. https://reviews.llvm.org/D26829 Files: lib/Lex/Lexer.cpp Index: lib/Lex/Lexer.cpp === --- lib/Lex/Lexer.cpp +++ lib/Lex/Lexer.c

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-17 Thread Eric Fiselier via cfe-commits
EricWF added a comment. Please add tests to `cxx1y-user-defined-literals.cpp` (and probably rename it). Other than that this LGTM, but I don't feel comfortable approving clang patches. https://reviews.llvm.org/D26829 ___ cfe-commits mailing list cf

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-18 Thread Malcolm Parsons via cfe-commits
malcolm.parsons added a comment. @mclow.lists is working on this in https://reviews.llvm.org/D26667. The review comments from that apply here too. https://reviews.llvm.org/D26829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.l

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-18 Thread Eric Fiselier via cfe-commits
EricWF added a comment. Should this review be closed then? https://reviews.llvm.org/D26829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-18 Thread Anton Bikineev via cfe-commits
AntonBikineev updated this revision to Diff 78490. https://reviews.llvm.org/D26829 Files: include/clang/Basic/DiagnosticLexKinds.td lib/Lex/Lexer.cpp Index: lib/Lex/Lexer.cpp === --- lib/Lex/Lexer.cpp +++ lib/Lex/Lexer.cpp @@ -

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-18 Thread Anton Bikineev via cfe-commits
AntonBikineev updated the summary for this revision. AntonBikineev updated this revision to Diff 78507. https://reviews.llvm.org/D26829 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp Index: lib/Lex/LiteralS

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-18 Thread Anton Bikineev via cfe-commits
AntonBikineev updated this revision to Diff 78510. https://reviews.llvm.org/D26829 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp Index: lib/Lex/LiteralSupport.cpp ==

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-18 Thread Anton Bikineev via cfe-commits
AntonBikineev updated this revision to Diff 78511. https://reviews.llvm.org/D26829 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp Index: lib/Lex/LiteralSupport.cpp ==

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-18 Thread Anton Bikineev via cfe-commits
AntonBikineev updated this revision to Diff 78523. AntonBikineev added a comment. Just added a small test case https://reviews.llvm.org/D26829 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp test/SemaCXX/

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-18 Thread Malcolm Parsons via cfe-commits
malcolm.parsons added a comment. Does `Sema::CheckLiteralOperatorDeclaration` need to check `StringLiteralParser::isValidUDSuffix`? https://reviews.llvm.org/D26829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bi

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-18 Thread Anton Bikineev via cfe-commits
AntonBikineev updated this revision to Diff 78602. https://reviews.llvm.org/D26829 Files: include/clang/Basic/DiagnosticLexKinds.td include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp lib/Sema/SemaDeclCXX.cpp test/SemaCXX/cxx1z-user-defined-literals.cpp In

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-18 Thread Anton Bikineev via cfe-commits
AntonBikineev added a comment. In https://reviews.llvm.org/D26829#599906, @malcolm.parsons wrote: > Does `Sema::CheckLiteralOperatorDeclaration` need to check > `StringLiteralParser::isValidUDSuffix`? Thanks, nice point! Just addressed it. https://reviews.llvm.org/D26829 _

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-18 Thread Richard Smith via cfe-commits
rsmith added inline comments. Comment at: include/clang/Basic/DiagnosticLexKinds.td:189-190 InGroup, DefaultIgnore; +def err_cxx1z_string_view_literal : Error< + "string_view literals are a C++1z feature">; def ext_binary_literal : Extension< I don't see a n

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-19 Thread Anton Bikineev via cfe-commits
AntonBikineev added inline comments. Comment at: lib/Lex/LiteralSupport.cpp:1716-1717 +StringLiteralParser::UDSuffixResult +StringLiteralParser::isValidUDSuffix(const LangOptions &LangOpts, + StringRef Suffix) { + if (!LangOpts.CPlusPlus11 ||

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-20 Thread Anton Bikineev via cfe-commits
AntonBikineev updated this revision to Diff 78654. AntonBikineev added a comment. Richard, thanks, I addressed your comments. https://reviews.llvm.org/D26829 Files: include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp lib/Sema/SemaDeclCXX.cpp test/SemaCXX/cx

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-21 Thread Richard Smith via cfe-commits
rsmith accepted this revision. rsmith added a comment. This revision is now accepted and ready to land. LGTM, thanks! Comment at: lib/Lex/Lexer.cpp:1717 + const StringRef CompleteSuffix(Buffer, Chars); + const LangOptions &LangOpts = getLangOpts(); +

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-21 Thread Anton Bikineev via cfe-commits
AntonBikineev updated this revision to Diff 78739. https://reviews.llvm.org/D26829 Files: include/clang/Lex/LiteralSupport.h lib/Lex/Lexer.cpp lib/Lex/LiteralSupport.cpp lib/Sema/SemaDeclCXX.cpp test/SemaCXX/cxx1z-user-defined-literals.cpp Index: test/SemaCXX/cxx1z-user-defined-litera

[PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-29 Thread Anton Bikineev via Phabricator via cfe-commits
AntonBikineev added a comment. @rsmith Richard, any plans to merge this or is there anything left? https://reviews.llvm.org/D26829 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D26829: [clang] Allow lexer to handle string_view literals

2016-11-19 Thread Richard Smith via cfe-commits
On 19 Nov 2016 2:36 am, "Anton Bikineev" wrote: AntonBikineev added inline comments. Comment at: lib/Lex/LiteralSupport.cpp:1716-1717 +StringLiteralParser::UDSuffixResult +StringLiteralParser::isValidUDSuffix(const LangOptions &LangOpts, + St