This revision was automatically updated to reflect the committed changes.
Closed by commit rL288334: [ObjC] Avoid a @try/@finally/@autoreleasepool fixit
when parsing an expression (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D26916?vs=78728=79893#toc
Repository:
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Thanks for the explanation, LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D26916
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
arphaman added inline comments.
Comment at: lib/Parse/ParseObjc.cpp:2877
+if (GetLookAheadToken(1).is(tok::l_brace) &&
+ExprStatementTokLoc == AtLoc) {
char ch = Tok.getIdentifierInfo()->getNameStart()[0];
bruno wrote:
> Does this
bruno added a comment.
Hi Alex, thanks for working on this
Comment at: lib/Parse/ParseObjc.cpp:2877
+if (GetLookAheadToken(1).is(tok::l_brace) &&
+ExprStatementTokLoc == AtLoc) {
char ch = Tok.getIdentifierInfo()->getNameStart()[0];
arphaman created this revision.
arphaman added reviewers: manmanren, bruno.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
This patch ensures that the typo fixit for the `@try/@finally/@autoreleasepool
{ }` directive is shown only when we're
