This revision was automatically updated to reflect the committed changes.
Closed by commit rL288436: Extend CompilationDatabase by a field for the output
filename (authored by joerg).
Changed prior to commit:
https://reviews.llvm.org/D27138?vs=79320=79993#toc
Repository:
rL LLVM
klimek accepted this revision.
klimek added a comment.
This revision is now accepted and ready to land.
In https://reviews.llvm.org/D27138#607859, @joerg wrote:
> Which struct are we talking about, `CompileCommandRef` or `CompileCommand`?
> It is a pointer in the former and a plain StringRef in
joerg added a comment.
Which struct are we talking about, `CompileCommandRef` or `CompileCommand`? It
is a pointer in the former and a plain StringRef in the latter. I don't think
making it a pointer in both is an advantage, i.e. distinguishing empty input
from missing field is not valuable in
klimek added a comment.
In https://reviews.llvm.org/D27138#607786, @joerg wrote:
> It's not the directory, but the output file. That's optional since it is a
> new addition and I don't want to invalidate all existing JSON databases.
It seems like we're talking past each other. I'm not
joerg added a comment.
It's not the directory, but the output file. That's optional since it is a new
addition and I don't want to invalidate all existing JSON databases.
Repository:
rL LLVM
https://reviews.llvm.org/D27138
___
cfe-commits
klimek added inline comments.
Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266
+nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])),
+Output ? Output->getValue(OutputStorage) : "");
}
joerg wrote:
> klimek wrote:
> > joerg wrote:
> >
joerg added a comment.
Can I interprete that as LGTM otherwise?
Repository:
rL LLVM
https://reviews.llvm.org/D27138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
joerg added inline comments.
Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266
+nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])),
+Output ? Output->getValue(OutputStorage) : "");
}
klimek wrote:
> joerg wrote:
> > klimek wrote:
> >
klimek added inline comments.
Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266
+nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])),
+Output ? Output->getValue(OutputStorage) : "");
}
joerg wrote:
> klimek wrote:
> > joerg wrote:
> >
joerg added inline comments.
Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266
+nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])),
+Output ? Output->getValue(OutputStorage) : "");
}
klimek wrote:
> joerg wrote:
> > klimek wrote:
> >
klimek added inline comments.
Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266
+nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])),
+Output ? Output->getValue(OutputStorage) : "");
}
joerg wrote:
> klimek wrote:
> > Optional: I'd
joerg added inline comments.
Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266
+nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])),
+Output ? Output->getValue(OutputStorage) : "");
}
klimek wrote:
> Optional: I'd probably let the
klimek added inline comments.
Comment at: lib/Tooling/JSONCompilationDatabase.cpp:266
+nodeToCommandLine(Syntax, std::get<2>(CommandsRef[I])),
+Output ? Output->getValue(OutputStorage) : "");
}
Optional: I'd probably let the nodeToCommandLine
joerg created this revision.
joerg added a reviewer: klimek.
joerg added a subscriber: cfe-commits.
joerg set the repository for this revision to rL LLVM.
In bigger projects like an Operating System, the same source code is often
compiled in slightly different ways. This could be the difference
14 matches
Mail list logo
