[PATCH] D27180: Testbed and skeleton of a new expression parser

This revision was automatically updated to reflect the committed changes. Closed by commit rL290367: Testbed and skeleton of a new expression parser (authored by spyffe). Changed prior to commit: https://reviews.llvm.org/D27180?vs=81991=82360#toc Repository: rL LLVM

[PATCH] D27180: Testbed and skeleton of a new expression parser

a.sidorin added a comment. Looks good now, thanks! Repository: rL LLVM https://reviews.llvm.org/D27180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

I don't know much about who owns this sort of code, nor Vassil's work/responsibility in this area - but if he's OK with it/feels able to sign off on it, that'd be sufficient/fine by me (& others closer to it can pipe up if he seems like not the right person to approve). Thanks! - Dave On Mon,

[PATCH] D27180: Testbed and skeleton of a new expression parser

spyffe updated this revision to Diff 81991. spyffe marked 3 inline comments as done. spyffe added a comment. Applied Aleksei's comments, and integrated all the CMakeFiles fixes required to make the bots happy. Repository: rL LLVM https://reviews.llvm.org/D27180 Files: test/CMakeLists.txt

Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

Reverted by 290130. I have new comments from Aleksei in https://reviews.llvm.org/D27180 . I'll apply those and update the patch. Sean > On Dec 19, 2016, at 9:48 AM, Sean Callanan wrote: > > David, > > thanks for keeping an eye on this

[PATCH] D27180: Testbed and skeleton of a new expression parser

a.sidorin added a comment. Sorry for being late :( Comment at: cfe/trunk/tools/clang-import-test/clang-import-test.cpp:99 +llvm::errs() << LineString << '\n'; +std::string Space(LocColumn, ' '); +llvm::errs() << Space.c_str() << '\n'; I still think

Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

David, thanks for keeping an eye on this and sorry for the breach of process. Would having Vassil approve the changelist (https://reviews.llvm.org/D27180 ) be appropriate? Let's say if he has any concerns or can't get to it by tomorrow, we revert my patches

Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

On 19/12/16 17:55, David Blaikie wrote: On Thu, Dec 15, 2016 at 2:18 PM Sean Callanan via Phabricator via cfe-commits > wrote: spyffe updated this revision to Diff 81661. spyffe marked 2 inline comments as done.

Re: [PATCH] D27180: Testbed and skeleton of a new expression parser

On Thu, Dec 15, 2016 at 2:18 PM Sean Callanan via Phabricator via cfe-commits wrote: > spyffe updated this revision to Diff 81661. > spyffe marked 2 inline comments as done. > spyffe added a comment. > Herald added a subscriber: jgosnell. > > Applied Vassil and

[PATCH] D27180: Testbed and skeleton of a new expression parser

This revision was automatically updated to reflect the committed changes. Closed by commit rL290004: Testbed and skeleton of a new expression parser (authored by spyffe). Changed prior to commit: https://reviews.llvm.org/D27180?vs=81803=81807#toc Repository: rL LLVM

[PATCH] D27180: Testbed and skeleton of a new expression parser

spyffe updated this revision to Diff 81803. spyffe added a comment. Updated CMakeFiles to fix dependencies. - Fixed dependencies on `gen_intrinsics` - Added a testsuite dependency on clang-import-test Repository: rL LLVM https://reviews.llvm.org/D27180 Files: test/CMakeLists.txt

[PATCH] D27180: Testbed and skeleton of a new expression parser

spyffe updated this revision to Diff 81661. spyffe marked 2 inline comments as done. spyffe added a comment. Herald added a subscriber: jgosnell. Applied Vassil and Vedant's comments. I will commit this soon. Repository: rL LLVM https://reviews.llvm.org/D27180 Files:

[PATCH] D27180: Testbed and skeleton of a new expression parser

v.g.vassilev added a comment. Could you move the Build* functions in a utility class/namespace. I need something very similar for my ongoing work on the libInterpreter patch and I'd like to reuse that part of the patch. Repository: rL LLVM https://reviews.llvm.org/D27180

[PATCH] D27180: Testbed and skeleton of a new expression parser

v.g.vassilev added a comment. Thanks for working on this Sean! Since long time we are planning to propose a patch moving some parts of cling (eg. libInterpreter) mainline. Now I should have a little more time to do this and it'd be great if we can share some code between cling and lldb. This

[PATCH] D27180: Testbed and skeleton of a new expression parser

vsk added a comment. Looks good. Apart from some nitpicks, I'm happy with this. This isn't really my area so it'd be good to get an explicit lgtm from one of the reviewers. Comment at: tools/clang-import-test/CMakeLists.txt:7 + clang-import-test.cpp + ) +

[PATCH] D27180: Testbed and skeleton of a new expression parser

spyffe updated this revision to Diff 79807. spyffe marked an inline comment as done. spyffe added a comment. Updated to reflect Vedant's comments. Also ensured 100% test coverage, by removing handling for errors that will never happen and by adding a few new tests. Repository: rL LLVM

[PATCH] D27180: Testbed and skeleton of a new expression parser

spyffe marked 3 inline comments as done. spyffe added a comment. Thank you for your review, Vedant! I will update the patch to reflect your comments in a moment. > I'm concerned about the amount of covered-but-untested code this patch > introduces. Since there are no CHECK lines, it's hard

[PATCH] D27180: Testbed and skeleton of a new expression parser

vsk added a comment. Thanks for working on this! I'm happy with the direction of this patch. It makes sense that clang would have a tool to help test AST reconstruction from 'external' sources. As you pointed out, it provides a good avenue for clients of the clang AST's to get better test

[PATCH] D27180: Testbed and skeleton of a new expression parser

spyffe updated this revision to Diff 79605. spyffe marked 2 inline comments as done. spyffe added a comment. Updated to reflect Aleksei's comments. Repository: rL LLVM https://reviews.llvm.org/D27180 Files: test/Import/empty-struct/Inputs/S.c test/Import/empty-struct/test.c

[PATCH] D27180: Testbed and skeleton of a new expression parser

spyffe marked 11 inline comments as done. spyffe added a comment. Thank you, Alex! I've responded in a few places inline below, and will update this patch momentarily. Comment at: tools/clang-import-test/clang-import-test.cpp:106 + +const char *LineEnd = nullptr; +

[PATCH] D27180: Testbed and skeleton of a new expression parser

spyffe added a comment. In https://reviews.llvm.org/D27180#607433, @hfinkel wrote: > This seems like a great idea. btw, do you know about Cling > (https://root.cern.ch/cling)? Hal, thank you for your interest! Yes, Cling is what I was referring to when I mentioned the ROOT project. Vassil

[PATCH] D27180: Testbed and skeleton of a new expression parser

a.sidorin added a comment. That's excellent. Thank you for this work, Sean! Comment at: tools/clang-import-test/CMakeLists.txt:19 + ) \ No newline at end of file Please add a newline here. Comment at:

[PATCH] D27180: Testbed and skeleton of a new expression parser

hfinkel added a comment. This seems like a great idea. btw, do you know about Cling (https://root.cern.ch/cling)? Repository: rL LLVM https://reviews.llvm.org/D27180 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27180: Testbed and skeleton of a new expression parser

spyffe created this revision. spyffe added reviewers: a.sidorin, beanz, loladiro, v.g.vassilev. spyffe added a subscriber: cfe-commits. spyffe set the repository for this revision to rL LLVM. Herald added a subscriber: mgorny. LLVM's JIT is now the foundation of dynamic-compilation features for