This revision was automatically updated to reflect the committed changes.
flx marked an inline comment as done.
Closed by commit rL289912: [clang-tidy] Do not move parameter if only
DeclRefExpr occurs inside of a loop (authored by flx).
Changed prior to commit:
alexfh added a comment.
Thanks, this is fine to commit.
https://reviews.llvm.org/D27187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
flx updated this revision to Diff 81693.
https://reviews.llvm.org/D27187
Files:
clang-tidy/performance/UnnecessaryValueParamCheck.cpp
test/clang-tidy/performance-unnecessary-value-param.cpp
Index: test/clang-tidy/performance-unnecessary-value-param.cpp
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
LG modulo comment.
Comment at: clang-tidy/utils/DeclRefExprUtils.cpp:127
+ match(findAll(declRefExpr(equalsNode(),
+
flx added a comment.
Do you have any more comments, Alex?
https://reviews.llvm.org/D27187
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
flx added inline comments.
Comment at: clang-tidy/utils/DeclRefExprUtils.cpp:127
+ match(findAll(declRefExpr(equalsNode(),
+unless(hasAncestor(stmt(anyOf(
+forStmt(), cxxForRangeStmt(), whileStmt(),
alexfh added inline comments.
Comment at: clang-tidy/utils/DeclRefExprUtils.cpp:127
+ match(findAll(declRefExpr(equalsNode(),
+unless(hasAncestor(stmt(anyOf(
+forStmt(), cxxForRangeStmt(), whileStmt(),
flx marked an inline comment as done.
flx added inline comments.
Comment at: clang-tidy/utils/DeclRefExprUtils.cpp:127
+ match(findAll(declRefExpr(equalsNode(),
+unless(hasAncestor(stmt(anyOf(
+forStmt(),
flx removed rL LLVM as the repository for this revision.
flx updated this revision to Diff 79550.
https://reviews.llvm.org/D27187
Files:
clang-tidy/performance/UnnecessaryValueParamCheck.cpp
clang-tidy/utils/DeclRefExprUtils.cpp
clang-tidy/utils/DeclRefExprUtils.h
alexfh added inline comments.
Comment at: clang-tidy/utils/DeclRefExprUtils.cpp:127
+ match(findAll(declRefExpr(equalsNode(),
+unless(hasAncestor(stmt(anyOf(
+forStmt(), cxxForRangeStmt(), whileStmt(),
flx created this revision.
flx added reviewers: alexfh, sbenza, aaron.ballman.
flx added a subscriber: cfe-commits.
flx set the repository for this revision to rL LLVM.
flx added a project: clang-tools-extra.
Herald added a subscriber: JDevlieghere.
This fixes a bug where the
11 matches
Mail list logo