This revision was automatically updated to reflect the committed changes.
Closed by commit rL292932: [CodeCompletion] Ensure that ObjC root class
completes instance (authored by arphaman).
Changed prior to commit:
https://reviews.llvm.org/D27257?vs=85400=85578#toc
Repository:
rL LLVM
bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
Ok. Thanks Alex, LGTM
Repository:
rL LLVM
https://reviews.llvm.org/D27257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
arphaman updated this revision to Diff 85400.
arphaman added a comment.
Add comment to parameter
Repository:
rL LLVM
https://reviews.llvm.org/D27257
Files:
lib/Sema/SemaCodeComplete.cpp
test/Index/complete-objc-message.m
Index: test/Index/complete-objc-message.m
arphaman marked an inline comment as done.
arphaman added a comment.
In https://reviews.llvm.org/D27257#652135, @bruno wrote:
> How does this interact (if at all) with classes annotated with
> `__attribute__((objc_root_class))`?
The root classes are just classes without a superclass, the
bruno added a comment.
How does this interact (if at all) with classes annotated with
`__attribute__((objc_root_class))`?
Comment at: lib/Sema/SemaCodeComplete.cpp:5259
SelIdents, CurContext, Selectors,
AllowSameLength, Results,
arphaman added a comment.
ping
Repository:
rL LLVM
https://reviews.llvm.org/D27257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman added a comment.
Ping.
Repository:
rL LLVM
https://reviews.llvm.org/D27257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arphaman created this revision.
arphaman added reviewers: bruno, akyrtzi.
arphaman added a subscriber: cfe-commits.
arphaman set the repository for this revision to rL LLVM.
Code completion results for class methods already include instance methods from
Objective-C root classes. This patch
