[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. In D27800#3235066 , @efriedma wrote: > Looks like all the review comments have been addressed. LGTM Thanks for the review, but unfortunately I found an issue right before committing, taking a look at it now. Repository: rG

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

efriedma accepted this revision. efriedma added a comment. This revision is now accepted and ready to land. Looks like all the review comments have been addressed. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27800/new/

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. @efriedma I know it has been a long time, but are you still able to review this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27800/new/ https://reviews.llvm.org/D27800 ___

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. Fixes https://github.com/llvm/llvm-project/issues/30390 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D27800/new/ https://reviews.llvm.org/D27800 ___ cfe-commits mailing list

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. Fixes https://github.com/llvm/llvm-project/issues/30390 Comment at: test/SemaCXX/pr31042.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -disable-free %s + efriedma wrote: > Oh, this testcase doesn't actually

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos updated this revision to Diff 398935. pmatos added a comment. Herald added a subscriber: wingo. Herald added a project: clang. After a long hiatus on this bug, this is still failing on HEAD so lets get it fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

efriedma added inline comments. Comment at: test/SemaCXX/pr31042.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -emit-llvm -disable-free %s + You need to use "-o -" or something like that to avoid generating a file pr31042.ll. Also, a comment

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos updated this revision to Diff 91980. pmatos marked an inline comment as done. https://reviews.llvm.org/D27800 Files: include/clang/Sema/Sema.h lib/Sema/SemaExpr.cpp test/SemaCXX/pr31042.cpp Index: test/SemaCXX/pr31042.cpp

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

efriedma added inline comments. Comment at: test/SemaCXX/pr31042.cpp:1 +// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -fsyntax-only -disable-free %s + Oh, this testcase doesn't actually crash on trunk without at least -emit-llvm because semantic analysis

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos updated this revision to Diff 91685. pmatos added a comment. Added missing testcase to previous patch. https://reviews.llvm.org/D27800 Files: include/clang/Sema/Sema.h lib/Sema/SemaExpr.cpp test/SemaCXX/pr31042.cpp Index: test/SemaCXX/pr31042.cpp

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos updated this revision to Diff 91684. pmatos added a comment. @efriedma I have uploaded a new patch taking your comments into consideration and rebased on most recent clang sources. https://reviews.llvm.org/D27800 Files: include/clang/Sema/Sema.h lib/Sema/SemaExpr.cpp Index:

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added inline comments. Comment at: lib/Sema/SemaExpr.cpp:4031 // C99 6.5.3.4p4: the type (an unsigned integer type) is size_t. + if (isUnevaluatedContext() && ExprKind == UETT_SizeOf && + TInfo->getType()->isVariablyModifiedType()) efriedma

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos marked 3 inline comments as done. pmatos added a comment. Thanks for the comments. https://reviews.llvm.org/D27800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

efriedma added inline comments. Comment at: lib/Sema/SemaExpr.cpp:4031 // C99 6.5.3.4p4: the type (an unsigned integer type) is size_t. + if (isUnevaluatedContext() && ExprKind == UETT_SizeOf && + TInfo->getType()->isVariablyModifiedType()) Is the

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos updated this revision to Diff 85328. pmatos added a comment. Here's an updated patch including the test. Hope this is now ok for submission. Please accept my apologies with regards to the delaying in submitting this. https://reviews.llvm.org/D27800 Files: include/clang/Sema/Sema.h

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. Ah no, my mistake. I had the patch applied when I ran the test. https://reviews.llvm.org/D27800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. Has this been fixed upstream already? https://reviews.llvm.org/D27800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. Apologies for the delay over the holiday season, I will look into this later on after office hours. https://reviews.llvm.org/D27800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

efriedma requested changes to this revision. efriedma added a comment. This revision now requires changes to proceed. Missing regression test in test/SemaCXX/. https://reviews.llvm.org/D27800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

ahatanak added a comment. Can you add a test case? https://reviews.llvm.org/D27800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos added a comment. @efriedma Here's the new patch, thanks for your help getting here. https://reviews.llvm.org/D27800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D27800: Add overload of TransformToPotentiallyEvaluated for TypeSourceInfo

pmatos created this revision. pmatos added a reviewer: efriedma. pmatos added a subscriber: cfe-commits. Adds overload of ransformToPotentiallyEvaluated for TypeSourceInfo to properly deal with VLAs in nested calls of sizeof and typeof. Fixes #31042. https://reviews.llvm.org/D27800 Files: