danielcdh updated this revision to Diff 82975.
danielcdh added a comment.
fix function name
https://reviews.llvm.org/D27832
Files:
lib/Driver/Tools.cpp
test/Driver/gold-lto-samplepgo.c
Index: test/Driver/gold-lto-samplepgo.c
mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM, but fix what @bruno spotted before committing.
https://reviews.llvm.org/D27832
___
cfe-commits mailing list
cfe-commits@lists.llv
bruno added inline comments.
Comment at: lib/Driver/Tools.cpp:2211
+ if (Arg *A = Args.getLastArg(options::OPT_fprofile_sample_use_EQ)) {
+StringRef fname = A->getValue();
+if (!llvm::sys::fs::exists(fname))
"fname" -> "FName", "FileName", etc, or any na
danielcdh updated this revision to Diff 81759.
danielcdh added a comment.
add a test.
https://reviews.llvm.org/D27832
Files:
lib/Driver/Tools.cpp
test/Driver/gold-lto-samplepgo.c
Index: test/Driver/gold-lto-samplepgo.c
===
--
mehdi_amini added a comment.
Is this covered by a driver test usually?
https://reviews.llvm.org/D27832
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
danielcdh created this revision.
danielcdh added reviewers: tejohnson, mehdi_amini, davidxl.
danielcdh added a subscriber: cfe-commits.
ThinLTO needs to pass down the sample profile file path to linker.
https://reviews.llvm.org/D27832
Files:
lib/Driver/Tools.cpp
Index: lib/Driver/Tools.cpp
