[PATCH] D28001: [X86] Teach Clang about -mfentry flag

This revision was automatically updated to reflect the committed changes. Closed by commit rL293649: [X86] Teach Clang about -mfentry flag (authored by niravd). Changed prior to commit: https://reviews.llvm.org/D28001?vs=83850=86442#toc Repository: rL LLVM https://reviews.llvm.org/D28001

[PATCH] D28001: [X86] Teach Clang about -mfentry flag

dberris accepted this revision. dberris added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D28001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28001: [X86] Teach Clang about -mfentry flag

niravd added inline comments. Comment at: include/clang/Driver/Options.td:1731 def mno_pie_copy_relocations : Flag<["-"], "mno-pie-copy-relocations">, Group; +def mfentry : Flag<["-"], "mfentry">, HelpText<"insert calls to fentry at function entry">, Flags<[CC1Option]>,

[PATCH] D28001: [X86] Teach Clang about -mfentry flag

niravd updated this revision to Diff 83850. niravd marked 2 inline comments as done. niravd added a comment. Address comments https://reviews.llvm.org/D28001 Files: include/clang/Driver/Options.td include/clang/Frontend/CodeGenOptions.def lib/CodeGen/CodeGenFunction.cpp

[PATCH] D28001: [X86] Teach Clang about -mfentry flag

mcrosier added inline comments. Comment at: test/CodeGen/fentry.c:11 + +//HAS: attributes #{{[0-9]+}} = { {{.*}}"fentry-call"="true"{{.*}} } +//NOHAS-NOT: attributes #{{[0-9]+}} = { {{.*}}"fentry-call"{{.*}} } mcrosier wrote: > I'd prefer we stick with the

[PATCH] D28001: [X86] Teach Clang about -mfentry flag

mcrosier added inline comments. Comment at: include/clang/Driver/Options.td:1731 def mno_pie_copy_relocations : Flag<["-"], "mno-pie-copy-relocations">, Group; +def mfentry : Flag<["-"], "mfentry">, HelpText<"insert calls to fentry at function entry">, Flags<[CC1Option]>,