mehdi_amini accepted this revision.
mehdi_amini added a comment.
This revision is now accepted and ready to land.
LGTM.
(I can't test because LLVM_USE_SANITIZE_COVERAGE seems broken on Darwin)
https://reviews.llvm.org/D28133
___
cfe-commits mailing
kcc updated this revision to Diff 82571.
kcc added a comment.
remove unneeded set(LLVM_LINK_COMPONENTS support)
https://reviews.llvm.org/D28133
Files:
CMakeLists.txt
fuzz/
fuzz/CMakeLists.txt
fuzz/cxa_demangle_fuzzer.cpp
Index: fuzz/cxa_demangle_fuzzer.cpp
===
kcc marked an inline comment as done.
kcc added a comment.
yes, removed.
https://reviews.llvm.org/D28133
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mehdi_amini added inline comments.
Comment at: fuzz/CMakeLists.txt:3
+if( LLVM_USE_SANITIZE_COVERAGE )
+ set(LLVM_LINK_COMPONENTS support)
+
This is a dependency on libLLVMSupport right? Why is this needed?
https://reviews.llvm.org/D28133
__
kcc created this revision.
kcc added reviewers: compnerd, mehdi_amini, mclow.lists.
kcc added a subscriber: cfe-commits.
Herald added a subscriber: mgorny.
All easy-to-find bugs in cxa_demangle where fixed now
(https://bugs.chromium.org/p/chromium/issues/detail?id=606626)
except for one (https://l
