alexfh added inline comments.
Comment at: docs/clang-tidy/index.rst:565
+An additional check enabled by ``check_clang_tidy.py`` ensures that
+if `CHECK-MESSAGES:` is used in a file then every warning or error
+must have an associated CHECK in that file.
Looks lik
jdennett updated this revision to Diff 82818.
jdennett added a comment.
Addressed review comments: double-backtick quoting, underscores for references
to FileCheck, and change "matcher tests" to "clang-tidy tests".
https://reviews.llvm.org/D28189
Files:
docs/clang-tidy/index.rst
Index: docs
jdennett marked 2 inline comments as done.
jdennett added a comment.
Thanks for the review. I've address your comments, and will check over the
(presumed-final) diff before submitting.
Comment at: docs/clang-tidy/index.rst:558
+typically the basic `CHECK` forms (`CHECK-MESSAG
alexfh added inline comments.
Comment at: docs/clang-tidy/index.rst:558
+typically the basic `CHECK` forms (`CHECK-MESSAGES` and `CHECK-FIXES`)
+are sufficient for matcher tests. Note that the `FileCheck`
+documentation mostly assumes the default prefix (`CHECK`), and hence
alexfh accepted this revision.
alexfh added a comment.
This revision is now accepted and ready to land.
Awesome! Thank you for adding clarity to this part.
Looks good with a couple of nits.
Comment at: docs/clang-tidy/index.rst:550
+separate `FileCheck`_ invocations: once with
