This revision was automatically updated to reflect the committed changes.
Closed by commit rL296518: Allow attributes before union definition (authored
by erichkeane).
Changed prior to commit:
https://reviews.llvm.org/D28266?vs=90056&id=90075#toc
Repository:
rL LLVM
https://reviews.llvm.org
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
LGTM, with one formatting nit.
Comment at: lib/Sema/SemaDeclAttr.cpp:6201
+void Sema::ProcessDeclAttributeDelayed(Decl *D, const AttributeList *AttrList)
{
+
erichkeane marked 6 inline comments as done.
erichkeane added a comment.
Thanks! Changes incoming.
https://reviews.llvm.org/D28266
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane updated this revision to Diff 90056.
erichkeane added a comment.
Response to Aaron's comments
https://reviews.llvm.org/D28266
Files:
include/clang/Sema/Sema.h
lib/Parse/ParseDeclCXX.cpp
lib/Sema/SemaDecl.cpp
lib/Sema/SemaDeclAttr.cpp
test/CodeGen/transparent-union.c
test/
aaron.ballman added a comment.
Some minor nits, but I think this is generally correct.
Comment at: include/clang/Sema/Sema.h:3059
void ProcessDeclAttributes(Scope *S, Decl *D, const Declarator &PD);
+ // Helper for delayed proccessing TransparentUnion attribute.
+ void Pro
erichkeane added a comment.
Hi guys-
Since this is a rework of Vlad's changes, I'm not sure you noticed that this
was a different review! Anyone have opinions? Additionally, I had 1 question
in SemaDecl.cpp that I think was right, otherwise I hope this is a pretty light
review.
https://revi
erichkeane added inline comments.
Comment at: lib/Sema/SemaDecl.cpp:13499
+ if (Attr)
+ProcessDeclAttributeList(S, New, Attr);
+
I wasn't sure if this was the correct change in here. My other option was to
move the above 2 lines (13495/13496) above these l
erichkeane created this revision.
erichkeane added reviewers: cfe-commits, bruno, aaron.ballman, rsmith.
This is an update of this patch: https://reviews.llvm.org/D25824
I cannot seem to get that review to update with my diff. This first patch
removes the dependency on isParsing and switches to
