[PATCH] D28298: [OpenMP] Add fields for flags in the offload entry descriptor.

Hahnfeld accepted this revision. Hahnfeld added a comment. This revision is now accepted and ready to land. LGTM https://reviews.llvm.org/D28298 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[PATCH] D28298: [OpenMP] Add fields for flags in the offload entry descriptor.

sfantao added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:250-252 + // \brief Flags associated the device global. + int32_t Flags; + Hahnfeld wrote: > sfantao wrote: > > Hahnfeld wrote: > > > Is that intentionally not in the `protected`

[PATCH] D28298: [OpenMP] Add fields for flags in the offload entry descriptor.

sfantao updated this revision to Diff 83236. sfantao marked 2 inline comments as done. sfantao added a comment. - Privatize Order, Flags and Kind of the offload entry. https://reviews.llvm.org/D28298 Files: lib/CodeGen/CGOpenMPRuntime.cpp lib/CodeGen/CGOpenMPRuntime.h

[PATCH] D28298: [OpenMP] Add fields for flags in the offload entry descriptor.

Hahnfeld added inline comments. Comment at: lib/CodeGen/CGOpenMPRuntime.h:250-252 + // \brief Flags associated the device global. + int32_t Flags; + sfantao wrote: > Hahnfeld wrote: > > Is that intentionally not in the `protected` section below? > Yes,

[PATCH] D28298: [OpenMP] Add fields for flags in the offload entry descriptor.

sfantao marked an inline comment as done. sfantao added a comment. Hi Jonas, Thanks for the review. Comment at: lib/CodeGen/CGOpenMPRuntime.h:250-252 + // \brief Flags associated the device global. + int32_t Flags; + Hahnfeld wrote: > Is that

[PATCH] D28298: [OpenMP] Add fields for flags in the offload entry descriptor.

Hahnfeld added a subscriber: cfe-commits. Hahnfeld added a comment. Otherwise SGTM Comment at: lib/CodeGen/CGOpenMPRuntime.h:250-252 + // \brief Flags associated the device global. + int32_t Flags; + Is that intentionally not in the `protected`