rnk added a comment.
I went ahead and landed https://reviews.llvm.org/rL291255 to try to fix
forward. Take a look and let me know if that's not the right fix.
Repository:
rL LLVM
https://reviews.llvm.org/D28320
___
cfe-commits mailing list
That test should be updated to explicitly specify the triple, that
should also fix the problem. I'll spin that change as soon as I can.
I agree that using the triple to determine the expected directory
layout is kind of bogus. I have no idea if cross-compiling CUDA is
even going to work...
Do
chapuni added a comment.
It fails with LLVM_DEFAULT_TARGET_TRIPLE=i686-pc-win32, on linux.
http://bb.pgr.jp/builders/ninja-x64-msvc-RA-centos6/builds/33445
Seems it assumes Windows' layout even if the host is not Windows.
128838
This revision was automatically updated to reflect the committed changes.
jlebar marked an inline comment as done.
Closed by commit rL291131: [Driver] Driver changes to support CUDA compilation
on Windows. (authored by jlebar).
Changed prior to commit:
jlebar marked an inline comment as done.
jlebar added a comment.
Thank you for the reviews!
Comment at: clang/lib/Driver/ToolChains.cpp:1819
Args.getLastArgValue(options::OPT_cuda_path_EQ));
- else {
+ else if (HostTriple.isOSLinux() || HostTriple.isMacOSX()) {
tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.
Comment at: clang/lib/Driver/ToolChains.cpp:1819
Args.getLastArgValue(options::OPT_cuda_path_EQ));
- else {
+ else if (HostTriple.isOSLinux() ||
jlebar created this revision.
jlebar added a reviewer: tra.
jlebar added a subscriber: cfe-commits.
For the most part this is straightforward: Just add a CudaInstallation
object to the MSVC and MinGW toolchains.
CudaToolChain has to override computeMSVCVersion so that
Clang::constructJob passes
