[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

2017-01-24 Thread Phabricator via Phabricator via cfe-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rL292938: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer. (authored by xazax). Changed prior to commit: https://reviews.llvm.org/D28667?vs=85014&id=85586#toc Repository: rL LL

[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

2017-01-24 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh accepted this revision. alexfh added a comment. This revision is now accepted and ready to land. LG https://reviews.llvm.org/D28667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

2017-01-19 Thread András Leitereg via Phabricator via cfe-commits
leanil updated this revision to Diff 85014. leanil added a comment. Add config parameter to control new functionality. Update the test cases accordingly. https://reviews.llvm.org/D28667 Files: clang-tidy/modernize/RawStringLiteralCheck.cpp clang-tidy/modernize/RawStringLiteralCheck.h test

[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

2017-01-19 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood added a comment. In https://reviews.llvm.org/D28667#650586, @leanil wrote: > In https://reviews.llvm.org/D28667#650585, @LegalizeAdulthood wrote: > > > In https://reviews.llvm.org/D28667#649626, @LegalizeAdulthood wrote: > > > > > Don't do this without introducing an option to t

[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

2017-01-19 Thread András Leitereg via Phabricator via cfe-commits
leanil added a comment. In https://reviews.llvm.org/D28667#650585, @LegalizeAdulthood wrote: > In https://reviews.llvm.org/D28667#649626, @LegalizeAdulthood wrote: > > > Don't do this without introducing an option to turn it off. > > > To clarify my reasoning: > You imposing your subjective idea

[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

2017-01-19 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood added a comment. In https://reviews.llvm.org/D28667#649626, @LegalizeAdulthood wrote: > Don't do this without introducing an option to turn it off. To clarify my reasoning: You imposing your subjective idea of goodness on the code, i.e. style. Other people will have differen

[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

2017-01-18 Thread Richard via Phabricator via cfe-commits
LegalizeAdulthood added a comment. Don't do this without introducing an option to turn it off. https://reviews.llvm.org/D28667 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

2017-01-18 Thread András Leitereg via Phabricator via cfe-commits
leanil updated this revision to Diff 84805. leanil added a comment. Add test cases for the new functionality. These should not produce warnings, because their raw string replacement would be longer. https://reviews.llvm.org/D28667 Files: clang-tidy/modernize/RawStringLiteralCheck.cpp clang

[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

2017-01-16 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh added inline comments. Comment at: test/clang-tidy/modernize-raw-string-literal.cpp:94 +char const *const Concatenated("\"foo\"" + "\"bar\""); leanil wrote: > alexfh wrote: > > Does this test fail without the patch? Also, sh

[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

2017-01-15 Thread András Leitereg via Phabricator via cfe-commits
leanil added inline comments. Comment at: test/clang-tidy/modernize-raw-string-literal.cpp:94 +char const *const Concatenated("\"foo\"" + "\"bar\""); alexfh wrote: > Does this test fail without the patch? Also, should there be a te

[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

2017-01-14 Thread Alexander Kornienko via Phabricator via cfe-commits
alexfh requested changes to this revision. alexfh added inline comments. This revision now requires changes to proceed. Comment at: test/clang-tidy/modernize-raw-string-literal.cpp:94 +char const *const Concatenated("\"foo\"" + "\"bar\"");

[PATCH] D28667: [clang-tidy] Don't modernize-raw-string-literal if replacement is longer.

2017-01-13 Thread András Leitereg via Phabricator via cfe-commits
leanil created this revision. leanil added reviewers: alexfh, LegalizeAdulthood, xazax.hun. leanil added a subscriber: cfe-commits. leanil added a project: clang-tools-extra. Herald added a subscriber: JDevlieghere. modernize-raw-string-literal suggests to replace e.g.: std::string s{ "foo \""