[PATCH] D28703: [clang] Emit `diagnose_if` warnings from system headers

2017-01-13 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM! https://reviews.llvm.org/D28703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[PATCH] D28703: [clang] Emit `diagnose_if` warnings from system headers

2017-01-13 Thread Eric Fiselier via Phabricator via cfe-commits
EricWF created this revision. EricWF added reviewers: george.burgess.iv, rsmith, aaron.ballman. EricWF added a subscriber: cfe-commits. In order for libc++ to meaningfully use `diagnose_if` warnings they need to be emitted from system headers by default. This patch changes the `diagnose_if` warn